Fix OOP iframe prototype to allow BrowserPlugin outside webview.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 1087 matching lines @@
 
 void ChromeContentRendererClient::RegisterPPAPIInterfaceFactories(
     webkit::ppapi::PpapiInterfaceFactoryManager* factory_manager) {
 #if defined(ENABLE_PLUGINS)
   factory_manager->RegisterFactory(ChromePPAPIInterfaceFactory);
 #endif
 }
 
 bool ChromeContentRendererClient::AllowBrowserPlugin(
     WebKit::WebPluginContainer* container) const {
+  // Always allow the BrowserPlugin in the site-per-process prototype.
+  if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kSitePerProcess))
+    return true;
+
   // If this |BrowserPlugin| <object> in the |container| is not inside a
   // <webview> shadowHost, we disable instantiating this plugin. This is to
   // discourage and prevent developers from accidentally attaching <object>
   // directly in apps.
   //
   // Note that this check below does *not* ensure any security, it is still
   // possible to bypass this check.
   // TODO(lazyboy): http://crbug.com/178663, Ensure we properly disallow
   // instantiating BrowserPlugin outside of the <webview> shim.
   if (container->element().isNull())
     return false;
 
   if (container->element().shadowHost().isNull())
     return false;
 
   if (container->element().shadowHost().tagName().equals(
           WebKit::WebString::fromUTF8(kWebViewTagName))) {
     return true;
   } else {
     return CommandLine::ForCurrentProcess()->HasSwitch(

[Fady Samuel, 2013/03/18 14:41:15]

While you're at it, could you please move this switch up to the top along
SitePerProcess.

[Charlie Reis, 2013/03/18 17:17:41]

Ah!  Just doing that move would be sufficient, actually.  We wouldn't need the
site-per-process flag check as well.

Done.

         switches::kEnableBrowserPluginForAllViewTypes);
   }
 }
 
 }  // namespace chrome