Fix OOP iframe prototype to allow BrowserPlugin outside webview.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 1087 matching lines @@
 
 void ChromeContentRendererClient::RegisterPPAPIInterfaceFactories(
     webkit::ppapi::PpapiInterfaceFactoryManager* factory_manager) {
 #if defined(ENABLE_PLUGINS)
   factory_manager->RegisterFactory(ChromePPAPIInterfaceFactory);
 #endif
 }
 
 bool ChromeContentRendererClient::AllowBrowserPlugin(
     WebKit::WebPluginContainer* container) const {
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableBrowserPluginForAllViewTypes))
+    return true;
+
   // If this |BrowserPlugin| <object> in the |container| is not inside a
   // <webview> shadowHost, we disable instantiating this plugin. This is to
   // discourage and prevent developers from accidentally attaching <object>
   // directly in apps.
   //
   // Note that this check below does *not* ensure any security, it is still
   // possible to bypass this check.
   // TODO(lazyboy): http://crbug.com/178663, Ensure we properly disallow
   // instantiating BrowserPlugin outside of the <webview> shim.
   if (container->element().isNull())
     return false;
 
   if (container->element().shadowHost().isNull())
     return false;
 
-  if (container->element().shadowHost().tagName().equals(
-          WebKit::WebString::fromUTF8(kWebViewTagName))) {
-    return true;
-  } else {
-    return CommandLine::ForCurrentProcess()->HasSwitch(
-        switches::kEnableBrowserPluginForAllViewTypes);
-  }
+  return container->element().shadowHost().tagName().equals(
+      WebKit::WebString::fromUTF8(kWebViewTagName));

[darin (slow to review), 2013/03/18 17:30:48]

nit: WebString has a using directive up top.

[Charlie Reis, 2013/03/18 17:33:13]

Done.

 }
 
 }  // namespace chrome