Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: runtime/observatory/tests/service/logging_test.dart

Issue 1247803002: Refactor dart:developer log to use named parameters (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/developer.dart ('k') | sdk/lib/_internal/js_runtime/lib/developer_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/logging_test.dart
diff --git a/runtime/observatory/tests/service/logging_test.dart b/runtime/observatory/tests/service/logging_test.dart
index 42f0140f2c634c6d2100403fedea2273ca457636..62b4857fdb7a4fe36db03fa75719379ed96f59ca 100644
--- a/runtime/observatory/tests/service/logging_test.dart
+++ b/runtime/observatory/tests/service/logging_test.dart
@@ -12,7 +12,17 @@ import 'test_helper.dart';
void init() {
Logger.root.level = Level.ALL;
- Logger.root.onRecord.listen(developer.logOnRecord);
+ Logger.root.onRecord.listen((logRecord) {
+ developer.log(
+ sequenceNumber: logRecord.sequenceNumber,
+ millisecondsSinceEpoch: logRecord.time.millisecondsSinceEpoch,
+ level: logRecord.level.value,
+ name: logRecord.loggerName,
+ message: logRecord.message,
+ zone: null,
+ error: logRecord.error,
+ stackTrace: logRecord.stackTrace);
+ });
}
void run() {
« no previous file with comments | « runtime/lib/developer.dart ('k') | sdk/lib/_internal/js_runtime/lib/developer_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698