Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1855)

Unified Diff: sdk/lib/_internal/js_runtime/lib/developer_patch.dart

Issue 1247803002: Refactor dart:developer log to use named parameters (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/logging_test.dart ('k') | sdk/lib/developer/developer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/js_runtime/lib/developer_patch.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/developer_patch.dart b/sdk/lib/_internal/js_runtime/lib/developer_patch.dart
index abc4ff198d8fa781cb1fae67376dec87891a7c2c..8ec8d4380b611354f109d32478094708f3ad8cea 100644
--- a/sdk/lib/_internal/js_runtime/lib/developer_patch.dart
+++ b/sdk/lib/_internal/js_runtime/lib/developer_patch.dart
@@ -41,13 +41,13 @@ inspect(object) {
/// [zone] (optional) the zone where the log was emitted
/// [error] (optional) an error object associated with this log event.
/// [stackTrace] (optional) a stack trace associated with this log event.
-log(int sequenceNumber,
- int millisecondsSinceEpoch,
- int level,
- String name,
- String message,
- [Zone zone,
+log({int sequenceNumber,
+ int millisecondsSinceEpoch,
+ int level,
+ String name,
+ String message,
+ Zone zone,
Object error,
- StackTrace stackTrace]) {
+ StackTrace stackTrace}) {
// TODO.
-}
+}
« no previous file with comments | « runtime/observatory/tests/service/logging_test.dart ('k') | sdk/lib/developer/developer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698