Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: runtime/lib/developer.dart

Issue 1247803002: Refactor dart:developer log to use named parameters (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/tests/service/logging_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/developer.dart
diff --git a/runtime/lib/developer.dart b/runtime/lib/developer.dart
index af3ead06630c69fd1edad3a61ac9a7de8fb905a1..242ef04603056d75b3e790633d60029161555881 100644
--- a/runtime/lib/developer.dart
+++ b/runtime/lib/developer.dart
@@ -6,11 +6,11 @@ patch bool debugger({bool when: true, String msg}) native "Developer_debugger";
patch inspect(object) native "Developer_inspect";
-patch log(int sequenceNumber,
- int millisecondsSinceEpoch,
- int level,
- String name,
- String message,
- [Zone zone,
+patch log({int sequenceNumber,
+ int millisecondsSinceEpoch,
+ int level,
+ String name,
+ String message,
+ Zone zone,
Object error,
- StackTrace stackTrace]) native "Developer_log";
+ StackTrace stackTrace}) native "Developer_log";
« no previous file with comments | « no previous file | runtime/observatory/tests/service/logging_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698