Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: runtime/observatory/tests/service/logging_test.dart

Issue 1247803002: Refactor dart:developer log to use named parameters (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/developer.dart ('k') | sdk/lib/_internal/js_runtime/lib/developer_patch.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--compile_all --error_on_bad_type --error_on_bad_override 4 // VMOptions=--compile_all --error_on_bad_type --error_on_bad_override
5 5
6 import 'dart:developer' as developer; 6 import 'dart:developer' as developer;
7 import 'package:observatory/service_io.dart'; 7 import 'package:observatory/service_io.dart';
8 import 'package:unittest/unittest.dart'; 8 import 'package:unittest/unittest.dart';
9 import 'package:logging/logging.dart'; 9 import 'package:logging/logging.dart';
10 10
11 import 'test_helper.dart'; 11 import 'test_helper.dart';
12 12
13 void init() { 13 void init() {
14 Logger.root.level = Level.ALL; 14 Logger.root.level = Level.ALL;
15 Logger.root.onRecord.listen(developer.logOnRecord); 15 Logger.root.onRecord.listen((logRecord) {
16 developer.log(
17 sequenceNumber: logRecord.sequenceNumber,
18 millisecondsSinceEpoch: logRecord.time.millisecondsSinceEpoch,
19 level: logRecord.level.value,
20 name: logRecord.loggerName,
21 message: logRecord.message,
22 zone: null,
23 error: logRecord.error,
24 stackTrace: logRecord.stackTrace);
25 });
16 } 26 }
17 27
18 void run() { 28 void run() {
19 developer.debugger(); 29 developer.debugger();
20 Logger.root.fine('Hey Buddy!'); 30 Logger.root.fine('Hey Buddy!');
21 developer.debugger(); 31 developer.debugger();
22 Logger.root.info('YES'); 32 Logger.root.info('YES');
23 } 33 }
24 34
25 var tests = [ 35 var tests = [
(...skipping 11 matching lines...) Expand all
37 expect(event.logRecord['level'], equals(Level.INFO)); 47 expect(event.logRecord['level'], equals(Level.INFO));
38 expect(event.logRecord['message'].valueAsString, equals('YES')); 48 expect(event.logRecord['message'].valueAsString, equals('YES'));
39 expect(event.logRecord['time'], new isInstanceOf<DateTime>()); 49 expect(event.logRecord['time'], new isInstanceOf<DateTime>());
40 }), 50 }),
41 ]; 51 ];
42 52
43 main(args) => runIsolateTests(args, 53 main(args) => runIsolateTests(args,
44 tests, 54 tests,
45 testeeBefore: init, 55 testeeBefore: init,
46 testeeConcurrent: run); 56 testeeConcurrent: run);
OLDNEW
« no previous file with comments | « runtime/lib/developer.dart ('k') | sdk/lib/_internal/js_runtime/lib/developer_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698