Clean up Enhanced Bookmark's data acquiring logic

Clean up Enhanced Bookmark's data acquiring logic

This CL:
1. makes EnhancedBookmarkModel a subclass of
EnhancedBookmarksBridge, which frees us from boilerplating. Also
EnhancedBookmarksBridge is removed, both for java and native.
2. removes enhanced_bookmarks java package and all class are
unified in enhancedbookmarks package.
3. adds ianwen@ to enhancedbookmark folder's owner list.

BUG=513509
Committed: https://crrev.com/ee37b0dffaa16a90f199a0e539c9382e0d0da3e6
Cr-Commit-Position: refs/heads/master@{#340491}

[Ian Wen, 2015-07-24 00:27:55]

ianwen@chromium.org changed reviewers:
+ kkimlabs@chromium.org, newt@chromium.org

[Kibeom Kim (inactive), 2015-07-24 06:30:55]

https://codereview.chromium.org/1247033009/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java
(left):

https://codereview.chromium.org/1247033009/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java:210:
public BookmarkId getDefaultFolder() {
I think having a single place controlling default folder is better for
readability and maintenance. Let's keep getDefaultFolder.

https://codereview.chromium.org/1247033009/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java
(right):

https://codereview.chromium.org/1247033009/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModel.java:24:
public class EnhancedBookmarksModel extends BookmarksBridge{
nit: a space before {

[Ian Wen, 2015-07-24 22:07:24]

Thank you for the review. All done.

[Kibeom Kim (inactive), 2015-07-24 22:15:38]

lgtm thanks!

[Ian Wen, 2015-07-24 22:31:57]

newt@: I removed enhanced_bookmarks package. ptal :P

[newt (away), 2015-07-24 22:48:06]

https://codereview.chromium.org/1247033009/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModelTest.java
(left):

https://codereview.chromium.org/1247033009/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModelTest.java:54:
public void testGetAllBookmarkIDsOrderedByCreationDate() throws
InterruptedException {
Should this test be moved to run against BookmarksModel now? Same for the tests
below.

[Ian Wen, 2015-07-24 22:53:44]

https://codereview.chromium.org/1247033009/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModelTest.java
(left):

https://codereview.chromium.org/1247033009/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksModelTest.java:54:
public void testGetAllBookmarkIDsOrderedByCreationDate() throws
InterruptedException {
On 2015/07/24 22:48:06, newt wrote:
> Should this test be moved to run against BookmarksModel now? Same for the
tests
> below.

Ah I moved this test to enhancedbookmarks package, yet it was not added to my
last git commit. Done.

[newt (away), 2015-07-24 22:56:19]

lgtm. thanks!

[Ian Wen, 2015-07-24 22:56:50]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-07-24 22:56:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkimlabs@chromium.org
Link to the patchset: https://codereview.chromium.org/1247033009/#ps60001
(title: "Add correct files to git commits")

[commit-bot: I haz the power, 2015-07-24 22:57:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1247033009/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1247033009/60001

[commit-bot: I haz the power, 2015-07-25 00:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-25 00:23:32]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ian Wen, 2015-07-27 16:31:36]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2015-07-27 16:32:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1247033009/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1247033009/60001

[commit-bot: I haz the power, 2015-07-27 17:17:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-27 17:17:56]

Patchset 4 (id:??) landed as
https://crrev.com/ee37b0dffaa16a90f199a0e539c9382e0d0da3e6
Cr-Commit-Position: refs/heads/master@{#340491}