Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java

Issue 1247033009: Clean up Enhanced Bookmark's data acquiring logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@icon_eb
Patch Set: Add correct files to git commits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
index fde48e8bb5aab2828940f41ae89e8762bf4b3d58..2908d03ce382bd79dd86e31d708ae5f4820f7be0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
@@ -488,7 +488,6 @@ public class BookmarksBridge {
* @return Id of the added node. If adding failed (index is invalid, string is null, parent is
* not editable), returns null.
*/
- @VisibleForTesting
public BookmarkId addFolder(BookmarkId parent, int index, String title) {
assert parent.getType() == BookmarkType.NORMAL;
assert index >= 0;
@@ -509,7 +508,6 @@ public class BookmarksBridge {
* @return Id of the added node. If adding failed (index is invalid, string is null, parent is
* not editable), returns null.
*/
- @VisibleForTesting
public BookmarkId addBookmark(BookmarkId parent, int index, String title, String url) {
assert parent.getType() == BookmarkType.NORMAL;
assert index >= 0;
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698