Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1474)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkItemsAdapter.java

Issue 1247033009: Clean up Enhanced Bookmark's data acquiring logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@icon_eb
Patch Set: Add correct files to git commits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkItemsAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkItemsAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkItemsAdapter.java
index 30c9e87e4d8c4cca88158e9e26d7b95dfda0ba35..75822be61c69f3017d47db53a06b3dc9ae474b5d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkItemsAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkItemsAdapter.java
@@ -86,7 +86,7 @@ class EnhancedBookmarkItemsAdapter extends RecyclerView.Adapter<RecyclerView.Vie
private int toSectionPosition(int globalPosition) {
int sectionPosition = globalPosition;
- for (List section : mSections) {
+ for (List<?> section : mSections) {
if (sectionPosition < section.size()) break;
sectionPosition -= section.size();
}
@@ -151,7 +151,7 @@ class EnhancedBookmarkItemsAdapter extends RecyclerView.Adapter<RecyclerView.Vie
}
private void removeItem(int position) {
- List section = getSection(position);
+ List<?> section = getSection(position);
assert section == mFolderSection || section == mBookmarkSection;
section.remove(toSectionPosition(position));
notifyItemRemoved(position);
@@ -162,7 +162,7 @@ class EnhancedBookmarkItemsAdapter extends RecyclerView.Adapter<RecyclerView.Vie
@Override
public int getItemCount() {
int count = 0;
- for (List section : mSections) {
+ for (List<?> section : mSections) {
count += section.size();
}
return count;
@@ -170,7 +170,7 @@ class EnhancedBookmarkItemsAdapter extends RecyclerView.Adapter<RecyclerView.Vie
@Override
public int getItemViewType(int position) {
- List section = getSection(position);
+ List<?> section = getSection(position);
if (section == mPromoHeaderSection) {
return PROMO_HEADER_VIEW;
@@ -247,7 +247,7 @@ class EnhancedBookmarkItemsAdapter extends RecyclerView.Adapter<RecyclerView.Vie
public void onEnhancedBookmarkDelegateInitialized(EnhancedBookmarkDelegate delegate) {
mDelegate = delegate;
mDelegate.addUIObserver(this);
- mDelegate.getModel().addModelObserver(mBookmarkModelObserver);
+ mDelegate.getModel().addObserver(mBookmarkModelObserver);
mPromoHeaderManager = new EnhancedBookmarkPromoHeader(mContext, this);
if (mPromoHeaderManager.shouldShow()) mPromoHeaderSection.add(null);
@@ -257,7 +257,7 @@ class EnhancedBookmarkItemsAdapter extends RecyclerView.Adapter<RecyclerView.Vie
@Override
public void onDestroy() {
mDelegate.removeUIObserver(this);
- mDelegate.getModel().removeModelObserver(mBookmarkModelObserver);
+ mDelegate.getModel().removeObserver(mBookmarkModelObserver);
mPromoHeaderManager.destroy();
}

Powered by Google App Engine
This is Rietveld 408576698