Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java

Issue 1247033009: Clean up Enhanced Bookmark's data acquiring logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@icon_eb
Patch Set: Add correct files to git commits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java
deleted file mode 100644
index e0e276238e117013b50744099939459cd984dec6..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks/EnhancedBookmarksBridge.java
+++ /dev/null
@@ -1,72 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.enhanced_bookmarks;
-
-import org.chromium.base.JNINamespace;
-import org.chromium.chrome.browser.profiles.Profile;
-import org.chromium.components.bookmarks.BookmarkId;
-
-/**
- * Access gate to C++ side enhanced bookmarks functionalities.
- */
-@JNINamespace("enhanced_bookmarks::android")
-public final class EnhancedBookmarksBridge {
- // TODO(ianwen): remove this bridge.
- private long mNativeEnhancedBookmarksBridge;
-
- /**
- * Creates a new enhanced bridge using the given profile.
- */
- public EnhancedBookmarksBridge(Profile profile) {
- mNativeEnhancedBookmarksBridge = nativeInit(profile);
- }
-
- public void destroy() {
- assert mNativeEnhancedBookmarksBridge != 0;
- nativeDestroy(mNativeEnhancedBookmarksBridge);
- mNativeEnhancedBookmarksBridge = 0;
- }
-
- /**
- * Adds a folder to the EnhancedBookmarkModel
- * @param parent The parent of this folder
- * @param index The position this folder should appear within the parent
- * @param title The title of the bookmark
- * @return The ID of the newly created folder.
- */
- public BookmarkId addFolder(BookmarkId parent, int index, String title) {
- return nativeAddFolder(mNativeEnhancedBookmarksBridge, parent, index, title);
- }
-
- /**
- * Adds a Bookmark to the EnhancedBookmarkModel
- * @param parent The parent of this bookmark
- * @param index The position this bookmark should appear within the parent
- * @param title The title of the bookmark
- * @param url URL of the bookmark
- * @return The ID of the newly created bookmark
- */
- public BookmarkId addBookmark(BookmarkId parent, int index, String title, String url) {
- return nativeAddBookmark(mNativeEnhancedBookmarksBridge, parent, index, title, url);
- }
-
- /**
- * Moves a bookmark to another folder, and append it at the end of the list of all children.
- * @param bookmarkId The item to be be moved
- * @param newParentId The new parent of the item
- */
- public void moveBookmark(BookmarkId bookmarkId, BookmarkId newParentId) {
- nativeMoveBookmark(mNativeEnhancedBookmarksBridge, bookmarkId, newParentId);
- }
-
- private native long nativeInit(Profile profile);
- private native void nativeDestroy(long nativeEnhancedBookmarksBridge);
- private native BookmarkId nativeAddFolder(long nativeEnhancedBookmarksBridge, BookmarkId parent,
- int index, String title);
- private native void nativeMoveBookmark(long nativeEnhancedBookmarksBridge,
- BookmarkId bookmarkId, BookmarkId newParentId);
- private native BookmarkId nativeAddBookmark(long nativeEnhancedBookmarksBridge,
- BookmarkId parent, int index, String title, String url);
-}

Powered by Google App Engine
This is Rietveld 408576698