Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1246193002: Moved GrGLFragmentProcessor definition to its own file (Closed)

Created:
5 years, 5 months ago by wangyix
Modified:
5 years, 5 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org, djsollen, tomhudson
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Moved GrGLFragmentProcessor definition to its own file BUG=skia: Committed: https://skia.googlesource.com/skia/+/6af0c9394301b9f976813cc6dbdbbfe779030fe1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -145 lines) Patch
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + src/gpu/gl/GrGLFragmentProcessor.h View 1 chunk +4 lines, -57 lines 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProcessor.h View 1 chunk +0 lines, -52 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLXferProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
wangyix
5 years, 5 months ago (2015-07-21 20:46:25 UTC) #2
joshualitt
On 2015/07/21 20:46:25, wangyix wrote: lgtm
5 years, 5 months ago (2015-07-21 21:33:58 UTC) #3
tomhudson
Good to see this happening - do we have any sort of plan?
5 years, 5 months ago (2015-07-22 02:30:09 UTC) #4
wangyix
added GrGLFragmentProcessor args struct for use with emitCode()
5 years, 5 months ago (2015-07-22 15:45:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246193002/1
5 years, 5 months ago (2015-07-22 17:13:58 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 17:21:20 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6af0c9394301b9f976813cc6dbdbbfe779030fe1

Powered by Google App Engine
This is Rietveld 408576698