Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 124393006: Remove throughput_tests (Closed)

Created:
6 years, 11 months ago by enne (OOO)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, alokp, Zhenyao Mo, Vangelis Kokkevis, tonyg, nduca
Visibility:
Public.

Description

Remove throughput_tests These have been replaced by Telemetry tests and are not being run anywhere. BUG=332167, 333357 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244382

Patch Set 1 #

Patch Set 2 : Remove throughput tests entirely #

Patch Set 3 : Remove change to window_snapshot.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1177 lines) Patch
M chrome/chrome_tests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls.html View 1 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls.js View 1 1 chunk +0 lines, -176 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_back_as_aligned_canvas.js View 1 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_back_as_aligned_image_data.js View 1 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_back_as_canvas.js View 1 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_back_as_gradient.js View 1 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_back_as_image.js View 1 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_back_as_white.js View 1 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_ball_as_canvas_sprite.js View 1 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_ball_as_filled_path.js View 1 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_ball_as_image.js View 1 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_ball_as_image_with_shadow.js View 1 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_ball_as_rect.js View 1 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/bouncing_balls_draw_ball_as_text.js View 1 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/chromium.png View 1 Binary file 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/kiddie_logo.png View 1 Binary file 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_common/parse_url.js View 1 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_draw_from_canvas/index.html View 1 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_fill_path/index.html View 1 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_text/index.html View 1 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/canvas2d_balls_with_shadow/index.html View 1 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/perf/rendering/throughput/compositing_huge_div/index.html View 1 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/test/perf/rendering/throughput_tests.cc View 1 1 chunk +0 lines, -616 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
enne (OOO)
I did a grep over all of Chromium and couldn't find anything using wait_pixel. Am ...
6 years, 11 months ago (2014-01-07 22:54:34 UTC) #1
Ken Russell (switch to Gerrit)
On 2014/01/07 22:54:34, enne wrote: > I did a grep over all of Chromium and ...
6 years, 11 months ago (2014-01-07 23:29:15 UTC) #2
enne (OOO)
junov: Is this something you can review? tonyg/vangelis: Do you know about the state of ...
6 years, 11 months ago (2014-01-09 18:52:24 UTC) #3
enne (OOO)
Changed this patch to just remove the throughput tests entirely. It does not appear as ...
6 years, 11 months ago (2014-01-10 19:31:25 UTC) #4
nduca
lgtm if it helps :)
6 years, 11 months ago (2014-01-10 19:41:07 UTC) #5
enne (OOO)
jamesr: content/renderer OWNERS sky: chrome/test OWNERS
6 years, 11 months ago (2014-01-10 20:47:59 UTC) #6
jamesr
lgtm
6 years, 11 months ago (2014-01-10 21:18:07 UTC) #7
sky
LGTM
6 years, 11 months ago (2014-01-10 21:32:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/124393006/70001
6 years, 11 months ago (2014-01-10 21:44:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/124393006/70001
6 years, 11 months ago (2014-01-10 23:12:37 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 23:01:36 UTC) #11
Message was sent while issue was closed.
Change committed as 244382

Powered by Google App Engine
This is Rietveld 408576698