Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 12438036: Update harfbuzz-ng to 0.9.14 from 0.9.10 (Closed)

Created:
7 years, 9 months ago by jungshik at Google
Modified:
7 years, 8 months ago
CC:
chromium-reviews, dpranke
Visibility:
Public.

Description

Update harfbuzz-ng to 0.9.14 from 0.9.10 Old revision: 34e6c3e3e452bdf6f93df565a70453a6e74d4c6e New revision: f872a17462a75a3493623747bf3a3fbe54556c7b What's new: - A lot of Indic shaping bugs as well as a work-around for bugs in FreeSans (Devanagari) - New Win8-style Myanmar shaper - New shaper for Tai Tham, Chan, New Tai Lue See NEWS file for more details. While I'm at this, I also 'fixed' README.chromium to make the copyright information show up in about:credits page. Two tests requiring rebaselines (khmer-selection and danda-space) are added to the list of expected failure until they're rebaselined. See also http://webkit.org/b/113450 BUG=chromium:96143 TEST=See comment #5 in the bug. TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191666

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : new files added #

Total comments: 1

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6197 lines, -2426 lines) Patch
A third_party/harfbuzz-ng/NEWS View 1 2 1 chunk +681 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/README.chromium View 1 2 3 4 5 1 chunk +16 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/harfbuzz.gyp View 1 2 3 4 5 2 chunks +8 lines, -0 lines 1 comment Download
M third_party/harfbuzz-ng/src/hb-atomic-private.hh View 1 2 3 4 5 2 chunks +14 lines, -14 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-blob.h View 1 2 3 4 5 2 chunks +26 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-blob.cc View 1 2 3 4 5 2 chunks +4 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer.h View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer.cc View 1 2 3 4 5 4 chunks +13 lines, -230 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-buffer-deserialize-json.hh View 1 2 1 chunk +643 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-buffer-deserialize-text.hh View 1 2 1 chunk +571 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer-private.hh View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
A third_party/harfbuzz-ng/src/hb-buffer-serialize.cc View 1 2 1 chunk +336 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-common.cc View 1 2 3 4 5 3 chunks +19 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-fallback-shape.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ft.cc View 1 2 3 4 5 3 chunks +4 lines, -11 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-gobject-enums.cc View 1 2 3 4 5 1 chunk +0 lines, -366 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-mutex-private.hh View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-type-private.hh View 1 2 3 4 5 6 chunks +21 lines, -9 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.cc View 1 2 3 4 5 6 chunks +15 lines, -7 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gpos-table.hh View 1 2 3 4 5 26 chunks +83 lines, -81 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsub-table.hh View 1 2 3 4 5 19 chunks +85 lines, -87 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsubgpos-private.hh View 1 2 3 4 5 24 chunks +292 lines, -159 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-private.hh View 1 2 3 4 5 4 chunks +62 lines, -9 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map.cc View 1 2 3 4 5 14 chunks +38 lines, -21 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map-private.hh View 1 2 3 4 5 5 chunks +35 lines, -8 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape.cc View 1 2 3 4 5 7 chunks +60 lines, -46 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic.cc View 1 2 3 4 5 5 chunks +28 lines, -30 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-arabic-fallback.hh View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-default.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc View 1 2 3 4 5 28 chunks +347 lines, -88 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-machine.hh View 1 2 3 11 chunks +29 lines, -29 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-machine.rl View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-private.hh View 1 2 3 4 5 3 chunks +3 lines, -240 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-table.cc View 1 2 1 chunk +869 lines, -0 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic-table.hh View 1 2 3 4 5 1 chunk +0 lines, -872 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar.cc View 1 2 1 chunk +545 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar-machine.hh View 1 2 1 chunk +391 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh View 1 2 3 4 5 5 chunks +38 lines, -10 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-sea.cc View 1 2 1 chunk +384 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/src/hb-ot-shape-complex-sea-machine.hh View 1 2 1 chunk +224 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-thai.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc View 1 2 3 4 5 2 chunks +46 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-fallback-private.hh View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc View 1 2 3 4 5 6 chunks +13 lines, -26 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-private.hh View 1 2 3 4 5 2 chunks +0 lines, -37 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-private.hh View 1 2 3 4 5 6 chunks +49 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape.cc View 1 2 3 4 5 4 chunks +8 lines, -9 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-shape-plan.cc View 1 2 3 4 5 2 chunks +7 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-shaper.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-shaper-private.hh View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-unicode-private.hh View 1 2 3 4 5 4 chunks +10 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-version.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-warning.cc View 1 2 3 4 5 1 chunk +30 lines, -3 lines 0 comments Download
A third_party/harfbuzz-ng/src/test-buffer-serialize.cc View 1 2 1 chunk +126 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
jungshik at Google
7 years, 9 months ago (2013-03-23 00:32:26 UTC) #1
jungshik at Google
Forgot to add new files to the CL
7 years, 9 months ago (2013-03-25 18:22:28 UTC) #2
jungshik at Google
Tony, can you review this ? Behdad (the maintainer of harfbuzz) made some changes and ...
7 years, 9 months ago (2013-03-25 19:16:39 UTC) #3
tony
LGTM, but make sure you get a green layout test try run (or at least ...
7 years, 9 months ago (2013-03-25 19:22:26 UTC) #4
jungshik at Google
Thank you for the review. 3 layout test failed. One of them is completely unrelated ...
7 years, 9 months ago (2013-03-26 23:10:47 UTC) #5
tony
I would update the patch to include webkit/tools/layout_tests/test_expectations.txt and mark the 2 related tests as ...
7 years, 9 months ago (2013-03-26 23:26:55 UTC) #6
jungshik at Google
Thank you for the advice. I'll do what you suggested. I'll also update the list ...
7 years, 9 months ago (2013-03-28 20:21:48 UTC) #7
jungshik at Google
https://codereview.chromium.org/12438036/diff/43001/webkit/tools/layout_tests/test_expectations.txt File webkit/tools/layout_tests/test_expectations.txt (right): https://codereview.chromium.org/12438036/diff/43001/webkit/tools/layout_tests/test_expectations.txt#newcode38 webkit/tools/layout_tests/test_expectations.txt:38: crbug.com/224428 [Linux] fast/text/international/khmer-selection.html [ Failure ] Tony, Is the ...
7 years, 9 months ago (2013-03-28 20:22:19 UTC) #8
tony
On 2013/03/28 20:22:19, Jungshik Shin wrote: > https://codereview.chromium.org/12438036/diff/43001/webkit/tools/layout_tests/test_expectations.txt > File webkit/tools/layout_tests/test_expectations.txt (right): > > https://codereview.chromium.org/12438036/diff/43001/webkit/tools/layout_tests/test_expectations.txt#newcode38 ...
7 years, 9 months ago (2013-03-28 20:30:19 UTC) #9
jungshik at Google
Thank you, Tony. I've just landed an upstream CL to suppress those 2 tests, but ...
7 years, 9 months ago (2013-03-28 22:28:44 UTC) #10
tony
Sounds good to me. Thanks! On 2013/03/28 22:28:44, Jungshik Shin wrote: > Thank you, Tony. ...
7 years, 9 months ago (2013-03-28 23:15:13 UTC) #11
jungshik at Google
Committing now that Webkit has rolled to include these two failures in LayoutTests/platform/chromium/TestExpectations.
7 years, 8 months ago (2013-03-29 23:45:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/12438036/71001
7 years, 8 months ago (2013-03-29 23:46:06 UTC) #13
commit-bot: I haz the power
Presubmit check for 12438036-71001 failed and returned exit status 1. INFO:root:Found 52 file(s). Running presubmit ...
7 years, 8 months ago (2013-03-29 23:46:23 UTC) #14
jungshik at Google
@cpu, can you give us owner review (third_party/), Thanks.
7 years, 8 months ago (2013-03-29 23:50:57 UTC) #15
jungshik at Google
@cpu, can you approve (third_party/ owner)? thanks
7 years, 8 months ago (2013-03-29 23:51:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/12438036/85001
7 years, 8 months ago (2013-04-01 18:07:26 UTC) #17
jungshik at Google
TBR'ing because behdad is the lead developer of harfbuzz-ng and tony is familiar with Webkit ...
7 years, 8 months ago (2013-04-01 18:08:06 UTC) #18
commit-bot: I haz the power
Change committed as 191666
7 years, 8 months ago (2013-04-01 21:30:36 UTC) #19
bungeman-chromium
7 years, 8 months ago (2013-04-17 18:28:34 UTC) #20
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/12438036/diff/85001/third_party/harfbu...
File third_party/harfbuzz-ng/harfbuzz.gyp (right):

https://chromiumcodereview.appspot.com/12438036/diff/85001/third_party/harfbu...
third_party/harfbuzz-ng/harfbuzz.gyp:68:
'src/hb-ot-shape-complex-indic-table.hh',
This (hb-ot-shape-complex-indic-table.hh) needs to be removed, as it was deleted
with
http://cgit.freedesktop.org/harfbuzz/commit/src/hb-ot-shape-complex-indic-tab...

(issue found with CMake gyp generator, see
https://codereview.chromium.org/12314014/ )

Powered by Google App Engine
This is Rietveld 408576698