Update harfbuzz-ng to 0.9.14 from 0.9.10

third_party/harfbuzz-ng/src/hb-ft.cc

 /*
  * Copyright © 2009  Red Hat, Inc.
  * Copyright © 2009  Keith Stribley
  *
  *  This is part of HarfBuzz, a text shaping library.
  *
  * Permission is hereby granted, without written agreement and without
  * license or royalty fees, to use, copy, modify, and distribute this
  * software and its documentation for any purpose, provided that the
  * above copyright notice and the following two paragraphs appear in
@@ skipping 35 matching lines @@
  * In general, this file does a fine job of what it's supposed to do.
  * There are, however, things that need more work:
  *
  *   - We don't handle any load_flags.  That definitely has API implications. :(
  *     I believe hb_ft_font_create() should take load_flags input.
  *     In particular, FT_Get_Advance() without the NO_HINTING flag seems to be
  *     buggy.
  *
  *   - We don't handle / allow for emboldening / obliqueing.
  *
- *   - Rounding, etc?
- *
- *   - In the future, we should add constructors to create fonts in font space.
- *
- *   - I believe transforms are not correctly implemented.  FreeType does not
- *     provide any API to get to the transform/delta set on the face. :(
- *
- *   - Always use FT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH?
+ *   - In the future, we should add constructors to create fonts in font space?
  *
  *   - FT_Load_Glyph() is exteremely costly.  Do something about it?
  */
 
 
 static hb_bool_t
 hb_ft_get_glyph (hb_font_t *font HB_UNUSED,
                  void *font_data,
                  hb_codepoint_t unicode,
                  hb_codepoint_t variation_selector,
@@ skipping 161 matching lines @@
 static hb_bool_t
 hb_ft_get_glyph_name (hb_font_t *font HB_UNUSED,
                       void *font_data,
                       hb_codepoint_t glyph,
                       char *name, unsigned int size,
                       void *user_data HB_UNUSED)
 {
   FT_Face ft_face = (FT_Face) font_data;
 
   hb_bool_t ret = !FT_Get_Glyph_Name (ft_face, glyph, name, size);
-  if (!ret || (size && !*name))
-    snprintf (name, size, "gid%u", glyph);
+  if (ret && (size && !*name))
+    ret = false;
 
   return ret;
 }
 
 static hb_bool_t
 hb_ft_get_glyph_from_name (hb_font_t *font HB_UNUSED,
                            void *font_data,
                            const char *name, int len, /* -1 means nul-terminated */
                            hb_codepoint_t *glyph,
                            void *user_data HB_UNUSED)
@@ skipping 139 matching lines @@
                     ft_face->size->metrics.y_ppem);
 
   return font;
 }
 
 
 /* Thread-safe, lock-free, FT_Library */
 
 static FT_Library ft_library;
 
-static
+static inline
 void free_ft_library (void)
 {
   FT_Done_FreeType (ft_library);
 }
 
 static FT_Library
 get_ft_library (void)
 {
 retry:
   FT_Library library = (FT_Library) hb_atomic_ptr_get (&ft_library);
@@ skipping 67 matching lines @@
 
 FT_Face
 hb_ft_font_get_face (hb_font_t *font)
 {
   if (font->destroy == (hb_destroy_func_t) FT_Done_Face ||
       font->destroy == (hb_destroy_func_t) _do_nothing)
     return (FT_Face) font->user_data;
 
   return NULL;
 }