Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: third_party/harfbuzz-ng/src/hb-ft.cc

Issue 12438036: Update harfbuzz-ng to 0.9.14 from 0.9.10 (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/harfbuzz-ng/src/hb-ft.cc
===================================================================
--- third_party/harfbuzz-ng/src/hb-ft.cc (리비전 191245)
+++ third_party/harfbuzz-ng/src/hb-ft.cc (작업 사본)
@@ -53,15 +53,8 @@
*
* - We don't handle / allow for emboldening / obliqueing.
*
- * - Rounding, etc?
+ * - In the future, we should add constructors to create fonts in font space?
*
- * - In the future, we should add constructors to create fonts in font space.
- *
- * - I believe transforms are not correctly implemented. FreeType does not
- * provide any API to get to the transform/delta set on the face. :(
- *
- * - Always use FT_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH?
- *
* - FT_Load_Glyph() is exteremely costly. Do something about it?
*/
@@ -242,8 +235,8 @@
FT_Face ft_face = (FT_Face) font_data;
hb_bool_t ret = !FT_Get_Glyph_Name (ft_face, glyph, name, size);
- if (!ret || (size && !*name))
- snprintf (name, size, "gid%u", glyph);
+ if (ret && (size && !*name))
+ ret = false;
return ret;
}
@@ -403,7 +396,7 @@
static FT_Library ft_library;
-static
+static inline
void free_ft_library (void)
{
FT_Done_FreeType (ft_library);

Powered by Google App Engine
This is Rietveld 408576698