Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1243483002: Port more uses of OwnPtr to std::unique_ptr (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -35 lines) Patch
M sky/engine/bindings/builtin_natives.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/engine/tonic/dart_library_loader.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/tonic/dart_library_loader.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M sky/engine/tonic/dart_snapshot_loader.h View 2 chunks +1 line, -2 lines 0 comments Download
M sky/engine/tonic/dart_snapshot_loader.cc View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/tonic/dart_state.h View 2 chunks +5 lines, -6 lines 0 comments Download
M sky/engine/tonic/dart_state.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M sky/engine/tonic/dart_timer_heap.h View 2 chunks +3 lines, -5 lines 0 comments Download
M sky/engine/tonic/dart_timer_heap.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Cutch
5 years, 5 months ago (2015-07-16 17:33:03 UTC) #2
abarth-chromium
LGTM https://codereview.chromium.org/1243483002/diff/1/sky/engine/tonic/dart_timer_heap.cc File sky/engine/tonic/dart_timer_heap.cc (right): https://codereview.chromium.org/1243483002/diff/1/sky/engine/tonic/dart_timer_heap.cc#newcode44 sky/engine/tonic/dart_timer_heap.cc:44: Task* task = it->second.release(); Please store the task ...
5 years, 5 months ago (2015-07-16 17:43:22 UTC) #4
Cutch
https://codereview.chromium.org/1243483002/diff/1/sky/engine/tonic/dart_timer_heap.cc File sky/engine/tonic/dart_timer_heap.cc (right): https://codereview.chromium.org/1243483002/diff/1/sky/engine/tonic/dart_timer_heap.cc#newcode44 sky/engine/tonic/dart_timer_heap.cc:44: Task* task = it->second.release(); On 2015/07/16 17:43:22, abarth-chromium wrote: ...
5 years, 5 months ago (2015-07-16 17:45:49 UTC) #5
Cutch
5 years, 5 months ago (2015-07-16 17:46:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f0e7a0d37b7153c9eabc8b2feed77344869352c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698