Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: sky/engine/tonic/dart_library_loader.h

Issue 1243483002: Port more uses of OwnPtr to std::unique_ptr (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/bindings/builtin_natives.cc ('k') | sky/engine/tonic/dart_library_loader.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SKY_ENGINE_TONIC_DART_LIBRARY_LOADER_H_ 5 #ifndef SKY_ENGINE_TONIC_DART_LIBRARY_LOADER_H_
6 #define SKY_ENGINE_TONIC_DART_LIBRARY_LOADER_H_ 6 #define SKY_ENGINE_TONIC_DART_LIBRARY_LOADER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <unordered_map> 10 #include <unordered_map>
11 #include <unordered_set> 11 #include <unordered_set>
12 #include <vector> 12 #include <vector>
13 13
14 #include "base/callback_forward.h" 14 #include "base/callback_forward.h"
15 #include "base/macros.h" 15 #include "base/macros.h"
16 #include "base/memory/weak_ptr.h" 16 #include "base/memory/weak_ptr.h"
17 #include "dart/runtime/include/dart_api.h" 17 #include "dart/runtime/include/dart_api.h"
18 #include "sky/engine/wtf/OwnPtr.h"
19 18
20 namespace blink { 19 namespace blink {
21 class DartDependency; 20 class DartDependency;
22 class DartDependencyCatcher; 21 class DartDependencyCatcher;
23 class DartLibraryProvider; 22 class DartLibraryProvider;
24 class DartState; 23 class DartState;
25 24
26 // TODO(abarth): This class seems more complicated than it needs to be. Is 25 // TODO(abarth): This class seems more complicated than it needs to be. Is
27 // there some way of simplifying this system? For example, we have a bunch 26 // there some way of simplifying this system? For example, we have a bunch
28 // of inner classes that could potentially be factored out in some other way. 27 // of inner classes that could potentially be factored out in some other way.
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 std::unordered_set<std::unique_ptr<Job>> jobs_; 76 std::unordered_set<std::unique_ptr<Job>> jobs_;
78 std::unordered_set<std::unique_ptr<DependencyWatcher>> dependency_watchers_; 77 std::unordered_set<std::unique_ptr<DependencyWatcher>> dependency_watchers_;
79 DartDependencyCatcher* dependency_catcher_; 78 DartDependencyCatcher* dependency_catcher_;
80 79
81 DISALLOW_COPY_AND_ASSIGN(DartLibraryLoader); 80 DISALLOW_COPY_AND_ASSIGN(DartLibraryLoader);
82 }; 81 };
83 82
84 } // namespace blink 83 } // namespace blink
85 84
86 #endif // SKY_ENGINE_TONIC_DART_LIBRARY_LOADER_H_ 85 #endif // SKY_ENGINE_TONIC_DART_LIBRARY_LOADER_H_
OLDNEW
« no previous file with comments | « sky/engine/bindings/builtin_natives.cc ('k') | sky/engine/tonic/dart_library_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698