Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "sky/engine/tonic/dart_timer_heap.h" | 5 #include "sky/engine/tonic/dart_timer_heap.h" |
| 6 | 6 |
| 7 #include "base/bind.h" | 7 #include "base/bind.h" |
| 8 #include "base/message_loop/message_loop.h" | 8 #include "base/message_loop/message_loop.h" |
| 9 #include "base/time/time.h" | 9 #include "base/time/time.h" |
| 10 #include "sky/engine/tonic/dart_api_scope.h" | 10 #include "sky/engine/tonic/dart_api_scope.h" |
| 11 #include "sky/engine/tonic/dart_invoke.h" | 11 #include "sky/engine/tonic/dart_invoke.h" |
| 12 #include "sky/engine/tonic/dart_isolate_scope.h" | 12 #include "sky/engine/tonic/dart_isolate_scope.h" |
| 13 #include "sky/engine/tonic/dart_state.h" | 13 #include "sky/engine/tonic/dart_state.h" |
| 14 | 14 |
| 15 namespace blink { | 15 namespace blink { |
| 16 | 16 |
| 17 DartTimerHeap::DartTimerHeap() : next_timer_id_(1), weak_factory_(this) { | 17 DartTimerHeap::DartTimerHeap() : next_timer_id_(1), weak_factory_(this) { |
| 18 } | 18 } |
| 19 | 19 |
| 20 DartTimerHeap::~DartTimerHeap() { | 20 DartTimerHeap::~DartTimerHeap() { |
| 21 } | 21 } |
| 22 | 22 |
| 23 int DartTimerHeap::Add(PassOwnPtr<Task> task) { | 23 int DartTimerHeap::Add(std::unique_ptr<Task> task) { |
| 24 int id = next_timer_id_++; | 24 int id = next_timer_id_++; |
| 25 Schedule(id, task); | 25 Schedule(id, std::move(task)); |
| 26 return id; | 26 return id; |
| 27 } | 27 } |
| 28 | 28 |
| 29 void DartTimerHeap::Remove(int id) { | 29 void DartTimerHeap::Remove(int id) { |
| 30 heap_.erase(id); | 30 heap_.erase(id); |
| 31 } | 31 } |
| 32 | 32 |
| 33 void DartTimerHeap::Schedule(int id, PassOwnPtr<Task> task) { | 33 void DartTimerHeap::Schedule(int id, std::unique_ptr<Task> task) { |
| 34 base::TimeDelta delay = task->delay; | 34 base::TimeDelta delay = task->delay; |
| 35 heap_[id] = task; | 35 heap_[id] = std::move(task); |
| 36 base::MessageLoop::current()->PostDelayedTask(FROM_HERE, | 36 base::MessageLoop::current()->PostDelayedTask(FROM_HERE, |
| 37 base::Bind(&DartTimerHeap::Run, weak_factory_.GetWeakPtr(), id), delay); | 37 base::Bind(&DartTimerHeap::Run, weak_factory_.GetWeakPtr(), id), delay); |
| 38 } | 38 } |
| 39 | 39 |
| 40 void DartTimerHeap::Run(int id) { | 40 void DartTimerHeap::Run(int id) { |
| 41 auto it = heap_.find(id); | 41 auto it = heap_.find(id); |
| 42 if (it == heap_.end()) | 42 if (it == heap_.end()) |
| 43 return; | 43 return; |
| 44 OwnPtr<Task> task = it->second.release(); | 44 Task* task = it->second.release(); |
|
abarth-chromium
2015/07/16 17:43:22
Please store the task in a st::unique_ptr on the s
Cutch
2015/07/16 17:45:49
Done.
| |
| 45 heap_.erase(it); | 45 heap_.erase(it); |
| 46 if (!task->closure.dart_state()) | 46 if (!task->closure.dart_state()) |
| 47 return; | 47 return; |
| 48 DartIsolateScope scope(task->closure.dart_state()->isolate()); | 48 DartIsolateScope scope(task->closure.dart_state()->isolate()); |
| 49 DartApiScope api_scope; | 49 DartApiScope api_scope; |
| 50 DartInvokeAppClosure(task->closure.value(), 0, nullptr); | 50 DartInvokeAppClosure(task->closure.value(), 0, nullptr); |
| 51 if (task->repeating) | 51 if (task->repeating) |
| 52 Schedule(id, task.release()); | 52 Schedule(id, std::unique_ptr<Task>(task)); |
| 53 } | 53 } |
| 54 | 54 |
| 55 } | 55 } |
| OLD | NEW |