Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: sky/engine/tonic/dart_snapshot_loader.cc

Issue 1243483002: Port more uses of OwnPtr to std::unique_ptr (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/tonic/dart_snapshot_loader.h ('k') | sky/engine/tonic/dart_state.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sky/engine/tonic/dart_snapshot_loader.h" 5 #include "sky/engine/tonic/dart_snapshot_loader.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/trace_event/trace_event.h" 8 #include "base/trace_event/trace_event.h"
9 #include "sky/engine/tonic/dart_api_scope.h" 9 #include "sky/engine/tonic/dart_api_scope.h"
10 #include "sky/engine/tonic/dart_converter.h" 10 #include "sky/engine/tonic/dart_converter.h"
(...skipping 10 matching lines...) Expand all
21 } 21 }
22 22
23 DartSnapshotLoader::~DartSnapshotLoader() { 23 DartSnapshotLoader::~DartSnapshotLoader() {
24 } 24 }
25 25
26 void DartSnapshotLoader::LoadSnapshot(mojo::ScopedDataPipeConsumerHandle pipe, 26 void DartSnapshotLoader::LoadSnapshot(mojo::ScopedDataPipeConsumerHandle pipe,
27 const base::Closure& callback) { 27 const base::Closure& callback) {
28 TRACE_EVENT_ASYNC_BEGIN0("sky", "DartSnapshotLoader::LoadSnapshot", this); 28 TRACE_EVENT_ASYNC_BEGIN0("sky", "DartSnapshotLoader::LoadSnapshot", this);
29 29
30 callback_ = callback; 30 callback_ = callback;
31 drainer_ = adoptPtr(new DataPipeDrainer(this, pipe.Pass())); 31 drainer_ = std::unique_ptr<mojo::common::DataPipeDrainer>(
32 new DataPipeDrainer(this, pipe.Pass()));
32 } 33 }
33 34
34 void DartSnapshotLoader::OnDataAvailable(const void* data, size_t num_bytes) { 35 void DartSnapshotLoader::OnDataAvailable(const void* data, size_t num_bytes) {
35 const uint8_t* bytes = static_cast<const uint8_t*>(data); 36 const uint8_t* bytes = static_cast<const uint8_t*>(data);
36 buffer_.insert(buffer_.end(), bytes, bytes + num_bytes); 37 buffer_.insert(buffer_.end(), bytes, bytes + num_bytes);
37 } 38 }
38 39
39 void DartSnapshotLoader::OnDataComplete() { 40 void DartSnapshotLoader::OnDataComplete() {
40 TRACE_EVENT_ASYNC_END0("sky", "DartSnapshotLoader::LoadSnapshot", this); 41 TRACE_EVENT_ASYNC_END0("sky", "DartSnapshotLoader::LoadSnapshot", this);
41 42
42 { 43 {
43 DartIsolateScope scope(dart_state_->isolate()); 44 DartIsolateScope scope(dart_state_->isolate());
44 DartApiScope api_scope; 45 DartApiScope api_scope;
45 46
46 LogIfError(Dart_LoadScriptFromSnapshot(buffer_.data(), buffer_.size())); 47 LogIfError(Dart_LoadScriptFromSnapshot(buffer_.data(), buffer_.size()));
47 } 48 }
48 49
49 callback_.Run(); 50 callback_.Run();
50 } 51 }
51 52
52 } // namespace blink 53 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/tonic/dart_snapshot_loader.h ('k') | sky/engine/tonic/dart_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698