Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1241953009: Remove CanLoadPage; it's essentially unused, and not compatible with (Closed)

Created:
5 years, 5 months ago by ncarter (slow)
Modified:
5 years, 5 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CanLoadPage; it's essentially unused, and not compatible with our plan for document blocking. BUG=268640 Committed: https://crrev.com/9cfbf5bdab7dc4d9544144d9c477711fd7db3761 Cr-Commit-Position: refs/heads/master@{#339568}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix the patch #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -46 lines) Patch
M content/browser/child_process_security_policy_impl.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 1 2 2 chunks +0 lines, -26 lines 0 comments Download
M content/browser/loader/resource_loader.cc View 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
ncarter (slow)
Charlie: as requested!
5 years, 5 months ago (2015-07-16 21:23:52 UTC) #2
Charlie Reis
Great. LGTM with nit. Context (for posterity): https://codereview.chromium.org/1208143002/diff/180001/content/browser/child_process_security_policy_impl.cc#newcode574 https://codereview.chromium.org/1241953009/diff/1/content/browser/child_process_security_policy_impl.cc File content/browser/child_process_security_policy_impl.cc (right): https://codereview.chromium.org/1241953009/diff/1/content/browser/child_process_security_policy_impl.cc#newcode553 content/browser/child_process_security_policy_impl.cc:553: bool ...
5 years, 5 months ago (2015-07-16 21:28:52 UTC) #3
Charlie Reis
[+site-isolation-reviews]
5 years, 5 months ago (2015-07-16 21:29:10 UTC) #4
ncarter (slow)
https://codereview.chromium.org/1241953009/diff/1/content/browser/child_process_security_policy_impl.cc File content/browser/child_process_security_policy_impl.cc (right): https://codereview.chromium.org/1241953009/diff/1/content/browser/child_process_security_policy_impl.cc#newcode553 content/browser/child_process_security_policy_impl.cc:553: bool ChildProcessSecurityPolicyImpl::CanLoadPage(int child_id, On 2015/07/16 21:28:51, Charlie Reis wrote: ...
5 years, 5 months ago (2015-07-16 23:14:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241953009/20001
5 years, 5 months ago (2015-07-16 23:16:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/74871)
5 years, 5 months ago (2015-07-17 00:02:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241953009/20001
5 years, 5 months ago (2015-07-17 23:08:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/75307)
5 years, 5 months ago (2015-07-17 23:14:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241953009/40001
5 years, 5 months ago (2015-07-20 23:20:38 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-20 23:59:26 UTC) #18
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 00:01:29 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9cfbf5bdab7dc4d9544144d9c477711fd7db3761
Cr-Commit-Position: refs/heads/master@{#339568}

Powered by Google App Engine
This is Rietveld 408576698