Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1239993005: Revert of Expose scroll customization for touch to JS (behind REF). (Closed)

Created:
5 years, 5 months ago by Julien - ping for review
Modified:
5 years, 5 months ago
Reviewers:
haraken, skobes, tdresser
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, kenneth.christiansen, rwlbuis, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Expose scroll customization for touch to JS (behind REF). (patchset #9 id:200001 of https://codereview.chromium.org/1209183004/) Reason for revert: The change introduced some leaks on our bots for: virtual/scroll_customization/fast/scroll-behavior/scroll-customization/scrollstate-distribute-to-scroll-chain-descendant.html virtual/scroll_customization/fast/scroll-behavior/scroll-customization/touch-scroll-customization.html Output is: ({"numberOfLiveActiveDOMObjects":[2,4],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,2]}) Full output: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/12632/steps/webkit_tests/logs/stdio Original issue's description: > Expose scroll customization for touch to JS (behind REF). > > This enables scroll customization of touch scrolls for JS. See > http://goo.gl/xCBm7L for details. This is a followup to > https://codereview.chromium.org/988823003, and completes landing > https://codereview.chromium.org/850443002/. > > This approach replaces the previous approach, from > https://codereview.chromium.org/1057603002. > > BUG=410974 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199049 TBR=haraken@chromium.org,skobes@chromium.org,tdresser@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=410974 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -700 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html View 1 chunk +45 lines, -45 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas.html View 2 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas-throw.html View 2 chunks +15 lines, -15 lines 0 comments Download
D LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-distribute-to-scroll-chain-descendant.html View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/fast/scroll-behavior/scroll-customization/touch-scroll-customization.html View 1 chunk +0 lines, -252 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/dom/Element.h View 3 chunks +3 lines, -10 lines 0 comments Download
M Source/core/dom/Element.cpp View 7 chunks +5 lines, -72 lines 0 comments Download
M Source/core/dom/Element.idl View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/core/input/EventHandler.cpp View 2 chunks +8 lines, -14 lines 0 comments Download
D Source/core/page/scrolling/ScrollCustomizationCallbacks.h View 1 chunk +0 lines, -45 lines 0 comments Download
D Source/core/page/scrolling/ScrollCustomizationCallbacks.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
M Source/core/page/scrolling/ScrollState.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollState.idl View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/page/scrolling/ScrollStateCallback.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/core/page/scrolling/ScrollStateCallback.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
D Source/core/page/scrolling/ScrollStateCallback.idl View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
Created Revert of Expose scroll customization for touch to JS (behind REF).
5 years, 5 months ago (2015-07-17 00:19:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239993005/1
5 years, 5 months ago (2015-07-17 00:20:27 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-07-17 00:20:46 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 00:21:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199065

Powered by Google App Engine
This is Rietveld 408576698