Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1209183004: Expose scroll customization for touch to JS (behind REF). (Closed)

Created:
5 years, 5 months ago by tdresser
Modified:
5 years, 5 months ago
Reviewers:
haraken, skobes
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, kenneth.christiansen, rwlbuis, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose scroll customization for touch to JS (behind REF). This enables scroll customization of touch scrolls for JS. See http://goo.gl/xCBm7L for details. This is a followup to https://codereview.chromium.org/988823003, and completes landing https://codereview.chromium.org/850443002/. This approach replaces the previous approach, from https://codereview.chromium.org/1057603002. BUG=410974 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199049

Patch Set 1 : Old Approach. #

Patch Set 2 : New approach. #

Patch Set 3 : Fix compile error. #

Patch Set 4 : Don't trigger layout on 0 delta. #

Total comments: 8

Patch Set 5 : Move callbacks from ElementRareData to static map. #

Patch Set 6 : Clean up static map. #

Total comments: 11

Patch Set 7 : Address haraken@'s comments. #

Patch Set 8 : Remove explicit, stop unnecessary element cleanup when disabled. #

Total comments: 14

Patch Set 9 : Address skobes' nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+700 lines, -93 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html View 1 chunk +45 lines, -45 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas.html View 2 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas-throw.html View 2 chunks +15 lines, -15 lines 0 comments Download
A LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-distribute-to-scroll-chain-descendant.html View 1 1 chunk +55 lines, -0 lines 0 comments Download
A LayoutTests/fast/scroll-behavior/scroll-customization/touch-scroll-customization.html View 1 1 chunk +252 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 7 8 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 1 2 3 4 3 chunks +10 lines, -3 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 4 5 6 7 8 7 chunks +72 lines, -5 lines 0 comments Download
M Source/core/dom/Element.idl View 1 2 3 4 5 6 7 8 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/input/EventHandler.cpp View 1 2 3 4 5 6 7 8 2 chunks +14 lines, -8 lines 0 comments Download
A Source/core/page/scrolling/ScrollCustomizationCallbacks.h View 1 2 3 4 5 1 chunk +45 lines, -0 lines 0 comments Download
A Source/core/page/scrolling/ScrollCustomizationCallbacks.cpp View 1 2 3 4 5 6 7 8 1 chunk +46 lines, -0 lines 0 comments Download
M Source/core/page/scrolling/ScrollState.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/scrolling/ScrollState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/scrolling/ScrollState.idl View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A Source/core/page/scrolling/ScrollStateCallback.h View 1 2 3 4 5 6 7 1 chunk +52 lines, -0 lines 0 comments Download
A Source/core/page/scrolling/ScrollStateCallback.cpp View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download
A Source/core/page/scrolling/ScrollStateCallback.idl View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 4 5 6 7 8 2 chunks +10 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (7 generated)
tdresser
https://codereview.chromium.org/1209183004/diff/100001/Source/core/dom/ElementRareData.h File Source/core/dom/ElementRareData.h (right): https://codereview.chromium.org/1209183004/diff/100001/Source/core/dom/ElementRareData.h#newcode165 Source/core/dom/ElementRareData.h:165: PersistentWillBeMember<ScrollStateCallback> m_distributeScroll; We need to find somewhere else to ...
5 years, 5 months ago (2015-07-06 20:43:01 UTC) #4
haraken
On 2015/07/06 20:43:01, tdresser wrote: > https://codereview.chromium.org/1209183004/diff/100001/Source/core/dom/ElementRareData.h > File Source/core/dom/ElementRareData.h (right): > > https://codereview.chromium.org/1209183004/diff/100001/Source/core/dom/ElementRareData.h#newcode165 > ...
5 years, 5 months ago (2015-07-07 02:11:05 UTC) #5
Rick Byers
This seems like a reasonable next step - thanks! I agree we don't want to ...
5 years, 5 months ago (2015-07-07 21:24:40 UTC) #6
tdresser
https://codereview.chromium.org/1209183004/diff/100001/Source/core/dom/Element.idl File Source/core/dom/Element.idl (right): https://codereview.chromium.org/1209183004/diff/100001/Source/core/dom/Element.idl#newcode21 Source/core/dom/Element.idl:21: // http://dev.w3.org/houdini/css-scroll-api/ On 2015/07/07 21:24:40, Rick Byers wrote: > ...
5 years, 5 months ago (2015-07-13 17:36:52 UTC) #7
haraken
https://codereview.chromium.org/1209183004/diff/100001/Source/core/dom/ElementRareData.h File Source/core/dom/ElementRareData.h (right): https://codereview.chromium.org/1209183004/diff/100001/Source/core/dom/ElementRareData.h#newcode165 Source/core/dom/ElementRareData.h:165: PersistentWillBeMember<ScrollStateCallback> m_distributeScroll; On 2015/07/13 17:36:52, tdresser wrote: > On ...
5 years, 5 months ago (2015-07-13 23:43:08 UTC) #9
tdresser
I've cleaned up the static map.
5 years, 5 months ago (2015-07-14 14:00:08 UTC) #10
tdresser
Rick is out for a week and a half - skobes he recommended you as ...
5 years, 5 months ago (2015-07-14 19:39:52 UTC) #12
haraken
bindings/ and dom/ LGTM https://codereview.chromium.org/1209183004/diff/140001/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (right): https://codereview.chromium.org/1209183004/diff/140001/Source/core/dom/Element.cpp#newcode143 Source/core/dom/Element.cpp:143: { Can we add ASSERT(RuntimeEnabledFeature::ScrollCustomization) ...
5 years, 5 months ago (2015-07-15 00:15:18 UTC) #13
tdresser
https://codereview.chromium.org/1209183004/diff/140001/Source/core/dom/Element.cpp File Source/core/dom/Element.cpp (right): https://codereview.chromium.org/1209183004/diff/140001/Source/core/dom/Element.cpp#newcode143 Source/core/dom/Element.cpp:143: { On 2015/07/15 00:15:18, haraken wrote: > > Can ...
5 years, 5 months ago (2015-07-15 14:04:55 UTC) #14
haraken
https://codereview.chromium.org/1209183004/diff/140001/Source/core/page/scrolling/ScrollStateCallback.h File Source/core/page/scrolling/ScrollStateCallback.h (right): https://codereview.chromium.org/1209183004/diff/140001/Source/core/page/scrolling/ScrollStateCallback.h#newcode18 Source/core/page/scrolling/ScrollStateCallback.h:18: ScrollStateCallback() On 2015/07/15 14:04:55, tdresser wrote: > On 2015/07/15 ...
5 years, 5 months ago (2015-07-15 14:07:17 UTC) #15
tdresser
5 years, 5 months ago (2015-07-15 14:32:05 UTC) #16
skobes
https://codereview.chromium.org/1209183004/diff/140001/Source/core/page/scrolling/ScrollState.idl File Source/core/page/scrolling/ScrollState.idl (right): https://codereview.chromium.org/1209183004/diff/140001/Source/core/page/scrolling/ScrollState.idl#newcode5 Source/core/page/scrolling/ScrollState.idl:5: // https://goo.gl/1ipTpP On 2015/07/15 00:15:18, haraken wrote: > > ...
5 years, 5 months ago (2015-07-15 19:52:41 UTC) #17
haraken
https://codereview.chromium.org/1209183004/diff/140001/Source/core/page/scrolling/ScrollState.idl File Source/core/page/scrolling/ScrollState.idl (right): https://codereview.chromium.org/1209183004/diff/140001/Source/core/page/scrolling/ScrollState.idl#newcode5 Source/core/page/scrolling/ScrollState.idl:5: // https://goo.gl/1ipTpP On 2015/07/15 19:52:40, skobes wrote: > On ...
5 years, 5 months ago (2015-07-15 23:33:19 UTC) #18
tdresser
https://codereview.chromium.org/1209183004/diff/180001/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html File LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html (right): https://codereview.chromium.org/1209183004/diff/180001/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html#newcode14 LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html:14: }, "These tests only work with scroll customization enabled."); ...
5 years, 5 months ago (2015-07-16 17:11:14 UTC) #19
skobes
lgtm https://codereview.chromium.org/1209183004/diff/180001/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html File LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html (right): https://codereview.chromium.org/1209183004/diff/180001/LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html#newcode14 LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-basic.html:14: }, "These tests only work with scroll customization ...
5 years, 5 months ago (2015-07-16 18:56:41 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209183004/200001
5 years, 5 months ago (2015-07-16 19:01:41 UTC) #23
commit-bot: I haz the power
Committed patchset #9 (id:200001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199049
5 years, 5 months ago (2015-07-16 19:06:44 UTC) #24
Julien - ping for review
A revert of this CL (patchset #9 id:200001) has been created in https://codereview.chromium.org/1239993005/ by jchaffraix@chromium.org. ...
5 years, 5 months ago (2015-07-17 00:19:54 UTC) #25
loyso (OOO)
This CL also causes TEXT size regression on Builder: Mac (stats) RESULT Chromium: Chromium= 8584 ...
5 years, 5 months ago (2015-07-17 03:52:40 UTC) #26
loyso (OOO)
5 years, 5 months ago (2015-07-17 04:11:44 UTC) #27
Message was sent while issue was closed.
https://build.chromium.org/p/chromium/builders/Mac/

Powered by Google App Engine
This is Rietveld 408576698