Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 850443002: Scroll Customization Prototype (Not for review, WIP) (Closed)

Created:
5 years, 11 months ago by tdresser
Modified:
5 years, 8 months ago
Reviewers:
CC:
blink-reviews, kenneth.christiansen, blink-reviews-html_chromium.org, arv+blink, blink-reviews-events_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Scroll Customization Prototype (Not for review, WIP) Touch only, with a bunch of simplifications. Both distributeScroll and scrollOverride work! BUG=410974

Patch Set 1 #

Patch Set 2 : Minor clean up. #

Patch Set 3 : Rename to applyScroll, add fromUserInput to ScrollState. #

Patch Set 4 : Prevent fling propagation. #

Patch Set 5 : Honour preventPropagation GSU bit, and use it for fling. #

Patch Set 6 : Handle the preventPropagation bit on gesture events. #

Patch Set 7 : Enable scroll customization in tests. #

Patch Set 8 : Improve preventPropagation handling. #

Patch Set 9 : Fix case where only one of applyScroll or distributeScroll are overwritten. #

Patch Set 10 : Fix broken scrolling when scroll customization was off. #

Patch Set 11 : Fix propagation across iframe boundaries. #

Patch Set 12 : Fix compile error, send ending events. #

Patch Set 13 : Fix failing layout tests. #

Patch Set 14 : Add virtual test suite. #

Patch Set 15 : Disable by default, fix expectations. #

Patch Set 16 : Rebase / cleanup / minor bug fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+983 lines, -54 lines) Patch
A LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-consume-deltas-throw.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-distribute-to-scroll-chain-descendant.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +54 lines, -0 lines 0 comments Download
A LayoutTests/fast/scroll-behavior/scroll-customization/scrollstate-simple.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +59 lines, -0 lines 0 comments Download
A LayoutTests/fast/scroll-behavior/scroll-customization/touch-scroll-customization.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +246 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +118 lines, -0 lines 0 comments Download
M Source/core/dom/Element.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +12 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 11 chunks +114 lines, -28 lines 0 comments Download
A Source/core/page/scrolling/ScrollState.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +107 lines, -0 lines 0 comments Download
A Source/core/page/scrolling/ScrollState.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +69 lines, -0 lines 0 comments Download
A Source/core/page/scrolling/ScrollState.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +30 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +9 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/PlatformGestureEvent.h View 5 chunks +29 lines, -16 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +6 lines, -5 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +6 lines, -1 line 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +4 lines, -3 lines 0 comments Download
M public/web/WebInputEvent.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
tdresser
Patchset #1 (id:1) has been deleted
5 years, 11 months ago (2015-01-10 17:53:36 UTC) #1
tdresser
Patchset #14 (id:280001) has been deleted
5 years, 10 months ago (2015-02-09 21:51:36 UTC) #2
tdresser
Patchset #14 (id:300001) has been deleted
5 years, 10 months ago (2015-02-09 21:51:43 UTC) #3
tdresser
Patchset #14 (id:320001) has been deleted
5 years, 10 months ago (2015-02-10 14:11:49 UTC) #4
tdresser
Patchset #14 (id:290033) has been deleted
5 years, 10 months ago (2015-02-10 14:11:58 UTC) #5
tdresser
Patchset #15 (id:370001) has been deleted
5 years, 10 months ago (2015-02-10 14:29:05 UTC) #6
tdresser
Patchset #14 (id:350001) has been deleted
5 years, 10 months ago (2015-02-10 14:29:13 UTC) #7
tdresser
Patchset #14 (id:390001) has been deleted
5 years, 10 months ago (2015-02-10 15:17:16 UTC) #8
tdresser
5 years, 10 months ago (2015-02-10 15:52:10 UTC) #9 
Patchset #14 (id:410001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698