Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 12390058: mac: Fix a few memory leaks. (Closed)

Created:
7 years, 6 months ago by Nico
Modified:
7 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

mac: Fix a few memory leaks. All found by clang's static analyzer. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185895

Patch Set 1 #

Patch Set 2 : cr #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M chrome/browser/ui/cocoa/applescript/element_applescript.mm View 1 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/password_generation_bubble_controller.mm View 2 chunks +11 lines, -11 lines 0 comments Download
M skia/ext/skia_utils_mac.mm View 1 chunk +3 lines, -1 line 2 comments Download
M ui/gfx/color_profile_mac.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 6 months ago (2013-03-04 14:11:17 UTC) #1
Robert Sesek
LGTM https://codereview.chromium.org/12390058/diff/4001/skia/ext/skia_utils_mac.mm File skia/ext/skia_utils_mac.mm (right): https://codereview.chromium.org/12390058/diff/4001/skia/ext/skia_utils_mac.mm#newcode366 skia/ext/skia_utils_mac.mm:366: base::mac::ScopedCFTypeRef<CGColorSpaceRef> color_space( It looks like the naming convention ...
7 years, 6 months ago (2013-03-04 14:47:53 UTC) #2
Nico
Thanks! https://codereview.chromium.org/12390058/diff/4001/skia/ext/skia_utils_mac.mm File skia/ext/skia_utils_mac.mm (right): https://codereview.chromium.org/12390058/diff/4001/skia/ext/skia_utils_mac.mm#newcode366 skia/ext/skia_utils_mac.mm:366: base::mac::ScopedCFTypeRef<CGColorSpaceRef> color_space( On 2013/03/04 14:47:53, rsesek wrote: > ...
7 years, 6 months ago (2013-03-04 14:52:35 UTC) #3
Nico
7 years, 6 months ago (2013-03-04 14:54:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r185895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698