skia/ext/skia_utils_mac.mm - Issue 12390058: mac: Fix a few memory leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/ext/skia_utils_mac.mm

Issue 12390058: mac: Fix a few memory leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cr Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/ext/skia_utils_mac.mm

diff --git a/skia/ext/skia_utils_mac.mm b/skia/ext/skia_utils_mac.mm

index c0db0132ab9ffabd4a32554a76fca25cd71147ab..687e776e84d99d65aacebe1bf36f33db50e9aa48 100644

--- a/skia/ext/skia_utils_mac.mm

+++ b/skia/ext/skia_utils_mac.mm

@@ -363,8 +363,10 @@ CGContextRef SkiaBitLocker::cgContext() {

bitmap_.allocPixels();

bitmap_.eraseColor(0);

}

+ base::mac::ScopedCFTypeRef<CGColorSpaceRef> color_space(

Robert Sesek 2013/03/04 14:47:53 It looks like the naming convention in skia is cam

Nico 2013/03/04 14:52:35 Yes, but this file is chromium code, not skia code

+ CGColorSpaceCreateDeviceRGB());

cgContext_ = CGBitmapContextCreate(bitmap_.getPixels(), bitmap_.width(),

- bitmap_.height(), 8, bitmap_.rowBytes(), CGColorSpaceCreateDeviceRGB(),

+ bitmap_.height(), 8, bitmap_.rowBytes(), color_space,

kCGBitmapByteOrder32Host | kCGImageAlphaPremultipliedFirst);

// Apply device matrix.