Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: chrome/browser/ui/cocoa/browser/password_generation_bubble_controller.mm

Issue 12390058: mac: Fix a few memory leaks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cr Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser/password_generation_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser/password_generation_bubble_controller.mm b/chrome/browser/ui/cocoa/browser/password_generation_bubble_controller.mm
index 5543250ba8bf8c45f2673988478ec57039760aed..b5dc68a93fb18ab18efc47adf956152051122a6b 100644
--- a/chrome/browser/ui/cocoa/browser/password_generation_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/browser/password_generation_bubble_controller.mm
@@ -327,15 +327,15 @@ const CGFloat kIconSize = 26.0;
NSView* contentView = [[self window] contentView];
ResourceBundle& rb = ResourceBundle::GetSharedInstance();
- textField_ =
- [[PasswordGenerationTextField alloc]
- initWithFrame:NSMakeRect(kBorderSize,
- kBorderSize,
- kTextFieldWidth,
- kTextFieldHeight + kTextFieldTopPadding)
- withController:self
- normalImage:rb.GetNativeImageNamed(IDR_RELOAD_DIMMED).ToNSImage()
- hoverImage:rb.GetNativeImageNamed(IDR_RELOAD).ToNSImage()];
+ textField_ = [[[PasswordGenerationTextField alloc]
+ initWithFrame:NSMakeRect(kBorderSize,
+ kBorderSize,
+ kTextFieldWidth,
+ kTextFieldHeight + kTextFieldTopPadding)
+ withController:self
+ normalImage:rb.GetNativeImageNamed(IDR_RELOAD_DIMMED).ToNSImage()
+ hoverImage:rb.GetNativeImageNamed(IDR_RELOAD)
+ .ToNSImage()] autorelease];
gfx::Font smallBoldFont =
rb.GetFont(ResourceBundle::SmallFont).DeriveFont(0, gfx::Font::BOLD);
[textField_ setFont:smallBoldFont.GetNativeFont()];
@@ -360,12 +360,12 @@ const CGFloat kIconSize = 26.0;
[button setAction:@selector(fillPassword:)];
[contentView addSubview:button];
- NSTextField* title = [[NSTextField alloc]
+ scoped_nsobject<NSTextField> title([[NSTextField alloc]
initWithFrame:NSMakeRect(
kBorderSize,
kBorderSize + kTextFieldHeight + kVerticalSpacing,
kTitleWidth,
- kTitleHeight)];
+ kTitleHeight)]);
[title setEditable:NO];
[title setBordered:NO];
[title setStringValue:l10n_util::GetNSString(

Powered by Google App Engine
This is Rietveld 408576698