Issue 12383047: Revert 185332

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12383047: Revert 185332 (Closed)

Created:
7 years, 9 months ago by tommi (sloooow) - chröme

Modified:
7 years, 9 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 185332 Speculative revert. All the GPU bots are currently red, failing at the compile stage. This time also reverting the skia roll even though a more recent version had been rolled. > Update khronos GLES2/gl2.h header > > BUG=178589 > > Review URL: https://codereview.chromium.org/12313140 TBR=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185521

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -20 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_c_lib_autogen.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_autogen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_interface_autogen.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_interface_stub_autogen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_trace_implementation_autogen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	gpu/command_buffer/cmd_buffer_functions.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/khronos/GLES2/gl2.h	View	5 chunks	+5 lines, -4 lines	0 comments	Download
M	third_party/khronos/README.chromium	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gl/generate_bindings.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/gl/gl_bindings_skia_in_process.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

tommi (sloooow) - chröme

7 years, 9 months ago (2013-03-01 10:48:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r185521.