Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1236863009: clang/win: Enable -Wunused-local-typedef (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
hans, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Enable -Wunused-local-typedef BUG=411648 TBR=jam Committed: https://crrev.com/803f983242c850986820e2f8de8a2f403086bea9 Cr-Commit-Position: refs/heads/master@{#339470}

Patch Set 1 #

Patch Set 2 : mesa #

Patch Set 3 : more #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : ipc #

Patch Set 7 : unsetupset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -13 lines) Patch
M base/compiler_specific.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/common/font_cache_dispatcher_win.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 1 2 1 chunk +18 lines, -7 lines 0 comments Download
M third_party/harfbuzz-ng/harfbuzz.gyp View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M third_party/mesa/BUILD.gn View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/mesa/mesa.gyp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/yasm/BUILD.gn View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/yasm/yasm.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Nico
5 years, 5 months ago (2015-07-18 17:03:12 UTC) #2
hans
Nice! lgtm
5 years, 5 months ago (2015-07-20 15:51:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236863009/120001
5 years, 5 months ago (2015-07-20 15:52:54 UTC) #5
Nico
tbr jam for content/common/font_cache_dispatcher_win.cc
5 years, 5 months ago (2015-07-20 15:55:10 UTC) #7
jam
lgtm
5 years, 5 months ago (2015-07-20 16:45:58 UTC) #8
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 5 months ago (2015-07-20 18:11:04 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 18:12:12 UTC) #10
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/803f983242c850986820e2f8de8a2f403086bea9
Cr-Commit-Position: refs/heads/master@{#339470}

Powered by Google App Engine
This is Rietveld 408576698