Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/harfbuzz-ng/BUILD.gn

Issue 1236863009: clang/win: Enable -Wunused-local-typedef (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unsetupset Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/font_cache_dispatcher_win.cc ('k') | third_party/harfbuzz-ng/harfbuzz.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/harfbuzz-ng/BUILD.gn
diff --git a/third_party/harfbuzz-ng/BUILD.gn b/third_party/harfbuzz-ng/BUILD.gn
index 6e735ab197fac842cfc1188c213810425d700ce1..76dde2458ee6323233fb8511f648dcdec2adef17 100644
--- a/third_party/harfbuzz-ng/BUILD.gn
+++ b/third_party/harfbuzz-ng/BUILD.gn
@@ -144,19 +144,30 @@ if (use_system_harfbuzz) {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
+
+ config("harfbuzz_warnings") {
+ cflags = []
+ if (is_clang) {
+ cflags += [
+ "-Wno-unused-value",
+ # Harfbuzz uses unused typedefs for its static asserts (and its
+ # static asserts are strange enough that they can't be replaced
+ # by static_assert).
+ "-Wno-unused-local-typedef",
+ ]
+ }
+ if (is_win) {
+ cflags += [ "/wd4334" ] # Result of 32-bit shift implicitly converted to 64 bits.
+ }
+ }
+ configs += [ ":harfbuzz_warnings" ]
+
public_configs = [ ":harfbuzz-ng_config" ]
deps = [
"//third_party/icu:icuuc",
]
- cflags = []
- if (is_clang) {
- cflags += [ "-Wno-unused-value" ]
- }
- if (is_win) {
- cflags += [ "/wd4334" ] # Result of 32-bit shift implicitly converted to 64 bits.
- }
if (is_mac) {
sources += [
"src/hb-coretext.cc",
« no previous file with comments | « content/common/font_cache_dispatcher_win.cc ('k') | third_party/harfbuzz-ng/harfbuzz.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698