base/compiler_specific.h - Issue 1236863009: clang/win: Enable -Wunused-local-typedef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/compiler_specific.h

Issue 1236863009: clang/win: Enable -Wunused-local-typedef (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unsetupset Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/compiler_specific.h

diff --git a/base/compiler_specific.h b/base/compiler_specific.h

index 66dc80db3198a9beb753d1073ffe982ac874ca06..a81afb57353182a978644e3704bcfc97ad024051 100644

--- a/base/compiler_specific.h

+++ b/base/compiler_specific.h

@@ -101,7 +101,7 @@

// Annotate a typedef or function indicating it's ok if it's not used.

// Use like:

// typedef Foo Bar ALLOW_UNUSED_TYPE;

-#if defined(COMPILER_GCC)

+#if defined(COMPILER_GCC) || defined(__clang__)

#define ALLOW_UNUSED_TYPE __attribute__((unused))

#else

#define ALLOW_UNUSED_TYPE

« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »