third_party/harfbuzz-ng/harfbuzz.gyp - Issue 1236863009: clang/win: Enable -Wunused-local-typedef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/harfbuzz-ng/harfbuzz.gyp

Issue 1236863009: clang/win: Enable -Wunused-local-typedef (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unsetupset Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/harfbuzz-ng/harfbuzz.gyp

diff --git a/third_party/harfbuzz-ng/harfbuzz.gyp b/third_party/harfbuzz-ng/harfbuzz.gyp

index b2f1d914667cf7cc2c6cc75889777c0dc7681187..d1853e8614e8c0e54f08a2480131e061462639be 100644

--- a/third_party/harfbuzz-ng/harfbuzz.gyp

+++ b/third_party/harfbuzz-ng/harfbuzz.gyp

@@ -135,7 +135,13 @@

'../../third_party/icu/icu.gyp:icuuc',

'variables': {

- 'clang_warning_flags': [ '-Wno-unused-value', ],

+ 'clang_warning_flags': [

+ '-Wno-unused-value',

+ # Harfbuzz uses unused typedefs for its static asserts (and its

+ # static asserts are strange enough that they can't be replaced

+ # by static_assert).

+ '-Wno-unused-local-typedef',

+ ],

'conditions': [

['OS=="win"', {

« no previous file with comments | « third_party/harfbuzz-ng/BUILD.gn ('k') | third_party/mesa/BUILD.gn » ('j') | no next file with comments »