Use new showSnackbar() method everywhere.

Use new showSnackbar() method everywhere.

This updates all the clients of showSnackbar() to use the new variant of
the method that takes a single Snackbar object. The old overloads of
showSnackbar() have been removed.

This also renames removeSnackbarEntry() to removeMatchingSnackbars(),
which seems like a clearer name.

Committed: https://crrev.com/12bfc3360892ec53cd00fc239a47e5298beb063b
Cr-Commit-Position: refs/heads/master@{#338390}

[newt (away), 2015-07-10 17:34:12]

newt@chromium.org changed reviewers:
+ dtrainor@chromium.org, ianwen@chromium.org

[newt (away), 2015-07-10 17:34:12]

PTAL

[Ian Wen, 2015-07-10 19:33:37]

lgtm

https://codereview.chromium.org/1235453002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
(right):

https://codereview.chromium.org/1235453002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java:196:
if (snackbar.getActionData() != null &&
snackbar.getActionData().equals(actionData)
This function might not work for removing snackbar with null objects. If
getActionData() returns null then it won't even compare.

Yet this is not a regression in this CL.

[newt (away), 2015-07-10 20:35:48]

https://codereview.chromium.org/1235453002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
(right):

https://codereview.chromium.org/1235453002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java:196:
if (snackbar.getActionData() != null &&
snackbar.getActionData().equals(actionData)
On 2015/07/10 19:33:37, Ian Wen wrote:
> This function might not work for removing snackbar with null objects. If
> getActionData() returns null then it won't even compare.
> 
> Yet this is not a regression in this CL.

Yeah. Calling this method doesn't make sense if actionData is null, and it
doesn't do anything. I think that's an OK situation.

[newt (away), 2015-07-10 20:35:53]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-07-10 20:36:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1235453002/1

[commit-bot: I haz the power, 2015-07-10 20:36:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-10 20:36:50]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[David Trainor- moved to gerrit, 2015-07-10 22:21:51]

lgtm

[newt (away), 2015-07-10 22:31:04]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-07-10 22:31:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1235453002/1

[commit-bot: I haz the power, 2015-07-10 23:10:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-10 23:11:42]

Patchset 1 (id:??) landed as
https://crrev.com/12bfc3360892ec53cd00fc239a47e5298beb063b
Cr-Commit-Position: refs/heads/master@{#338390}