chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java - Issue 1235453002: Use new showSnackbar() method everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

Issue 1235453002: Use new showSnackbar() method everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

index 3160bd9762488850b85bcb6cf81ddfd581929b06..1f3f40ed985bbde8120eced378676866a7fe3da1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java

@@ -39,10 +39,11 @@ public class LoFiBarPopupController implements SnackbarManager.SnackbarControlle

public void showLoFiBar(Tab tab) {

mTab = tab;

- mSnackbarManager.showSnackbar(

- null, mContext.getString(R.string.data_reduction_lo_fi_snackbar_message),

- mContext.getString(R.string.data_reduction_lo_fi_snackbar_action),

- tab.getId(), this, DEFAULT_LO_FI_SNACKBAR_SHOW_DURATION_MS);

+ mSnackbarManager.showSnackbar(Snackbar.make(

+ mContext.getString(R.string.data_reduction_lo_fi_snackbar_message), this)

+ .setAction(mContext.getString(R.string.data_reduction_lo_fi_snackbar_action),

+ tab.getId())

+ .setDuration(DEFAULT_LO_FI_SNACKBAR_SHOW_DURATION_MS));

DataReductionProxyUma.dataReductionProxyLoFiUIAction(

DataReductionProxyUma.ACTION_LOAD_IMAGES_SNACKBAR_SHOWN);

}

@@ -51,7 +52,7 @@ public class LoFiBarPopupController implements SnackbarManager.SnackbarControlle

* Dismisses the snackbar.

public void dismissLoFiBar() {

- if (mSnackbarManager.isShowing()) mSnackbarManager.removeSnackbarEntry(this);

+ if (mSnackbarManager.isShowing()) mSnackbarManager.removeMatchingSnackbars(this);

}

/**