chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java - Issue 1235453002: Use new showSnackbar() method everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

Issue 1235453002: Use new showSnackbar() method everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUndoController.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/LoFiBarPopupController.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

index a4a8d08f40197cf3a997af392857f100a8482c5b..4282fc14dc21f816de386f517ff373b7199106e2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

@@ -24,6 +24,7 @@ import org.chromium.chrome.browser.document.ChromeLauncherActivity;

import org.chromium.chrome.browser.enhanced_bookmarks.EnhancedBookmarksModel;

import org.chromium.chrome.browser.favicon.FaviconHelper;

import org.chromium.chrome.browser.profiles.Profile;

+import org.chromium.chrome.browser.snackbar.Snackbar;

import org.chromium.chrome.browser.snackbar.SnackbarManager;

import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;

import org.chromium.chrome.browser.util.FeatureUtilities;

@@ -90,10 +91,9 @@ public class EnhancedBookmarkUtils {

pair.first.destroy();

}

};

- snackbarManager.showSnackbar(null,

- activity.getString(R.string.enhanced_bookmark_page_saved),

- activity.getString(R.string.enhanced_bookmark_item_edit), pair,

- snackbarController);

+ snackbarManager.showSnackbar(Snackbar.make(

+ activity.getString(R.string.enhanced_bookmark_page_saved), snackbarController)

+ .setAction(activity.getString(R.string.enhanced_bookmark_item_edit), pair));

}

/**