chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUndoController.java - Issue 1235453002: Use new showSnackbar() method everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUndoController.java

Issue 1235453002: Use new showSnackbar() method everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUndoController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUndoController.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUndoController.java

index 93f8f9ff358bd2489556d872c93d2ae9aaa279d1..54ef3deb72a54c496f5678c87913c55bb688b462 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUndoController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUndoController.java

@@ -11,6 +11,7 @@ import org.chromium.chrome.browser.BookmarksBridge.BookmarkItem;

import org.chromium.chrome.browser.BookmarksBridge.BookmarkModelObserver;

import org.chromium.chrome.browser.enhanced_bookmarks.EnhancedBookmarksModel;

import org.chromium.chrome.browser.enhanced_bookmarks.EnhancedBookmarksModel.EnhancedBookmarkDeleteObserver;

+import org.chromium.chrome.browser.snackbar.Snackbar;

import org.chromium.chrome.browser.snackbar.SnackbarManager;

import java.util.Locale;

@@ -87,14 +88,14 @@ public class EnhancedBookmarkUndoController extends BookmarkModelObserver implem

if (!isUndoable) return;

if (titles.length == 1) {

- mSnackbarManager.showSnackbar(mContext.getString(R.string.undo_bar_delete_message),

- titles[0], mContext.getString(R.string.undo_bar_button_text),

- null, this);

+ mSnackbarManager.showSnackbar(Snackbar.make(titles[0], this)

+ .setTemplateText(mContext.getString(R.string.undo_bar_delete_message))

+ .setAction(mContext.getString(R.string.undo_bar_button_text), null));

} else {

mSnackbarManager.showSnackbar(

- mContext.getString(R.string.undo_bar_multiple_delete_message),

- String.format(Locale.getDefault(), "%d", titles.length),

- mContext.getString(R.string.undo_bar_button_text), null, this);

+ Snackbar.make(String.format(Locale.getDefault(), "%d", titles.length), this)

+ .setTemplateText(mContext.getString(R.string.undo_bar_multiple_delete_message))

+ .setAction(mContext.getString(R.string.undo_bar_button_text), null));

}