Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <resources xmlns:tools="http://schemas.android.com/tools"> | 6 <resources xmlns:tools="http://schemas.android.com/tools"> |
| 7 <!-- Q: Why put style resources under values-v17/ ? | 7 <!-- Q: Why put style resources under values-v17/ ? |
| 8 A: Problem: | 8 A: Problem: |
| 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. | 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. |
| 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert | 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert |
| 11 paddingStart to paddingLeft for pre-v17 (crbug.com/235118). | 11 paddingStart to paddingLeft for pre-v17 (crbug.com/235118). |
| 12 3. However, style files are not overrided by the corresponding gener ated style files, | 12 3. However, style files are not overrided by the corresponding gener ated style files, |
| 13 but merged when we pass them to aapt unlike layout files. | 13 but merged when we pass them to aapt unlike layout files. |
| 14 | 14 |
| 15 So we decided to keep style resources under values-v17/ so that it i s not merged with | 15 So we decided to keep style resources under values-v17/ so that it i s not merged with |
| 16 the generated style resources under res_v14_compatibility/values/ (c rbug.com/243952). | 16 the generated style resources under res_v14_compatibility/values/ (c rbug.com/243952). |
| 17 --> | 17 --> |
| 18 | 18 |
| 19 <style name="MainTheme" parent="Theme.AppCompat.Light.NoActionBar"> | 19 <style name="MainTheme" parent="Theme.AppCompat.Light.NoActionBar"> |
| 20 <item name="android:windowContentOverlay">@null</item> | 20 <item name="android:windowContentOverlay">@null</item> |
| 21 <item name="android:textColorHighlight">@color/text_highlight_color</ite m> | 21 <item name="android:textColorHighlight">@color/text_highlight_color</ite m> |
| 22 <item name="android:statusBarColor" tools:targetApi="21">@android:color/ black</item> | 22 <item name="android:statusBarColor" tools:targetApi="21">@android:color/ black</item> |
| 23 <item name="windowActionModeOverlay">true</item> | |
|
Yusuf
2015/07/23 05:23:34
why do we need this one? Does it not change the be
Ian Wen
2015/07/29 01:15:06
Oh. This flag is to tell the CAB bar to overlay on
| |
| 23 | 24 |
| 24 <!-- Overriding AppCompat values --> | 25 <!-- Overriding AppCompat values --> |
| 25 <item name="colorControlNormal">@color/light_normal_color</item> | 26 <item name="colorControlNormal">@color/light_normal_color</item> |
| 26 <item name="colorControlActivated">@color/light_active_color</item> | 27 <item name="colorControlActivated">@color/light_active_color</item> |
| 27 | 28 |
| 28 <!-- Default TintedImageButton tint --> | 29 <!-- Default TintedImageButton tint --> |
| 29 <item name="tint">@color/dark_mode_tint</item> | 30 <item name="tint">@color/dark_mode_tint</item> |
| 30 | 31 |
| 31 <!-- Navigation Transitions, requires API level 21 --> | 32 <!-- Navigation Transitions, requires API level 21 --> |
| 32 <item name="android:windowAllowEnterTransitionOverlap" tools:targetApi=" 21">false</item> | 33 <item name="android:windowAllowEnterTransitionOverlap" tools:targetApi=" 21">false</item> |
| (...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 394 <style name="LocationBarButton"> | 395 <style name="LocationBarButton"> |
| 395 <item name="android:background">@null</item> | 396 <item name="android:background">@null</item> |
| 396 </style> | 397 </style> |
| 397 <style name="ToolbarButton"> | 398 <style name="ToolbarButton"> |
| 398 <item name="android:background">?attr/selectableItemBackground</item> | 399 <item name="android:background">?attr/selectableItemBackground</item> |
| 399 <item name="android:layout_width">48dp</item> | 400 <item name="android:layout_width">48dp</item> |
| 400 <item name="android:layout_height">56dp</item> | 401 <item name="android:layout_height">56dp</item> |
| 401 <item name="android:scaleType">center</item> | 402 <item name="android:scaleType">center</item> |
| 402 </style> | 403 </style> |
| 403 </resources> | 404 </resources> |
| OLD | NEW |