Chromium Code Reviews

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 1235383002: Stop UI jumping when clicking Contextual Search Results in Custom Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move flag from xml to java Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
index efeef0faa2af439ad728ccd13b87159087bf80c6..74ac2b0f78ee0c6068d3ad93073a2702525787ee 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
@@ -13,6 +13,7 @@ import android.view.MenuItem;
import android.view.View;
import android.view.View.OnClickListener;
import android.view.ViewGroup;
+import android.view.Window;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.Log;
@@ -119,6 +120,7 @@ public class CustomTabActivity extends ChromeActivity {
}
});
mIntentDataProvider = new CustomTabIntentDataProvider(getIntent(), this);
+ supportRequestWindowFeature(Window.FEATURE_ACTION_MODE_OVERLAY);
}
@Override
@@ -236,6 +238,7 @@ public class CustomTabActivity extends ChromeActivity {
@Override
public boolean createContextualSearchTab(ContentViewCore searchContentViewCore) {
if (mTab == null) return false;
+ getCurrentContentViewCore().clearSelection();
NavigationEntry entry =
searchContentViewCore.getWebContents().getNavigationController().getPendingEntry();
String url = entry != null
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine