Chromium Code Reviews Chromium Code Reviews
Issue
1235293003:
Implement filter effects region for reference filters. (Closed)
DescriptionImplement filter effects region for reference filters.
The guts of this change are to set the filter region from
the target HTML element's bounding box for reference
filters (SVG filters applied to HTML content). This change
also bakes the filter region into the Skia crop rects of
all leaf nodes of the DAG (all 0-input filters, and all
filters whose inputs are all unconnected (NULL)). In the
future, this will allow us to remove the bounds from the
filtering saveLayer() calls, and leave the rendering
unchanged.
Since we no longer compute the filter region automatically (not spec compliant), the tests were modified
where possible to produce the same results. Where not,
the changes are minor pixel diffs.
Changed ReferenceFilterBuilder to actually
build a ReferenceFilter, instead of taking one as a
parameter, so it can retrieve the target bounding box
from the Element* and set it on the new ReferenceFilter.
Removed a now-unnecessary workaround from SVGFEImage.
Removed m_targetBoundingBox from SVGFilter (this should've
been in my last patch).
BUG=240827, 240845
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199232
Patch Set 1 #Patch Set 2 : Integrate leaf node into getCropRect(), add more tests, remove targetBoundingBox from SVGFilter #Patch Set 3 : Update to ToT #Patch Set 4 : TestExpectations cleanup #Patch Set 5 : Copyright and comment fixes for filterRegions.html. #Patch Set 6 : More copyright and test comment fixes #Patch Set 7 : Revert unnecessary changes; fix TestExpectations #
Total comments: 6
Patch Set 8 : Update to ToT #Patch Set 9 : Fixes per review comments #Messages
Total messages: 11 (6 generated)
|
