Source/core/svg/graphics/filters/SVGFEImage.cpp - Issue 1235293003: Implement filter effects region for reference filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/graphics/filters/SVGFEImage.cpp

Issue 1235293003: Implement filter effects region for reference filters. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixes per review comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/graphics/filters/SVGFEImage.cpp

diff --git a/Source/core/svg/graphics/filters/SVGFEImage.cpp b/Source/core/svg/graphics/filters/SVGFEImage.cpp

index cd732c75010b8b72cf34d7fcedf4eff85d2824ff..ef2b564e75ac9468d85c795fa5b4ceb6d9ec0bef 100644

--- a/Source/core/svg/graphics/filters/SVGFEImage.cpp

+++ b/Source/core/svg/graphics/filters/SVGFEImage.cpp

@@ -197,11 +197,6 @@ PassRefPtr<SkImageFilter> FEImage::createImageFilter(SkiaImageFilterBuilder* bui

FloatRect srcRect = FloatRect(FloatPoint(), m_image->size());

FloatRect dstRect = filterPrimitiveSubregion();

- // FIXME: CSS image filters currently do not seem to set filter primitive

- // subregion correctly if unspecified. So default to srcRect size if so.

- if (dstRect.isEmpty())

- dstRect = srcRect;

m_preserveAspectRatio->transformRect(dstRect, srcRect);

SkBitmap bitmap;