Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: Source/core/paint/FilterEffectBuilder.cpp

Issue 1235293003: Implement filter effects region for reference filters. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixes per review comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayer.cpp ('k') | Source/core/svg/graphics/filters/SVGFEImage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/FilterEffectBuilder.cpp
diff --git a/Source/core/paint/FilterEffectBuilder.cpp b/Source/core/paint/FilterEffectBuilder.cpp
index 5469a81de6804fcff3483ac8768b863b7ac35238..90157dc8cbc5fb40c3b402d2759092660dad078e 100644
--- a/Source/core/paint/FilterEffectBuilder.cpp
+++ b/Source/core/paint/FilterEffectBuilder.cpp
@@ -81,10 +81,11 @@ bool FilterEffectBuilder::build(Element* element, const FilterOperations& operat
FilterOperation* filterOperation = operations.operations().at(i).get();
switch (filterOperation->type()) {
case FilterOperation::REFERENCE: {
- RefPtrWillBeRawPtr<ReferenceFilter> referenceFilter = ReferenceFilter::create(zoom);
- effect = ReferenceFilterBuilder::build(referenceFilter.get(), element, previousEffect.get(), toReferenceFilterOperation(*filterOperation));
- referenceFilter->setLastEffect(effect);
- m_referenceFilters.append(referenceFilter);
+ RefPtrWillBeRawPtr<ReferenceFilter> referenceFilter = ReferenceFilterBuilder::build(zoom, element, previousEffect.get(), toReferenceFilterOperation(*filterOperation));
+ if (referenceFilter) {
+ effect = referenceFilter->lastEffect();
+ m_referenceFilters.append(referenceFilter);
+ }
break;
}
case FilterOperation::GRAYSCALE: {
« no previous file with comments | « Source/core/paint/DeprecatedPaintLayer.cpp ('k') | Source/core/svg/graphics/filters/SVGFEImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698