Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayer.cpp

Issue 1235293003: Implement filter effects region for reference filters. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixes per review comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 2560 matching lines...) Expand 10 before | Expand all | Expand 10 after
2571 FilterOperations DeprecatedPaintLayer::computeFilterOperations(const ComputedSty le& style) 2571 FilterOperations DeprecatedPaintLayer::computeFilterOperations(const ComputedSty le& style)
2572 { 2572 {
2573 const FilterOperations& filters = style.filter(); 2573 const FilterOperations& filters = style.filter();
2574 if (filters.hasReferenceFilter()) { 2574 if (filters.hasReferenceFilter()) {
2575 for (size_t i = 0; i < filters.size(); ++i) { 2575 for (size_t i = 0; i < filters.size(); ++i) {
2576 FilterOperation* filterOperation = filters.operations().at(i).get(); 2576 FilterOperation* filterOperation = filters.operations().at(i).get();
2577 if (filterOperation->type() != FilterOperation::REFERENCE) 2577 if (filterOperation->type() != FilterOperation::REFERENCE)
2578 continue; 2578 continue;
2579 ReferenceFilterOperation& referenceOperation = toReferenceFilterOper ation(*filterOperation); 2579 ReferenceFilterOperation& referenceOperation = toReferenceFilterOper ation(*filterOperation);
2580 // FIXME: Cache the ReferenceFilter if it didn't change. 2580 // FIXME: Cache the ReferenceFilter if it didn't change.
2581 RefPtrWillBeRawPtr<ReferenceFilter> referenceFilter = ReferenceFilte r::create(style.effectiveZoom()); 2581 RefPtrWillBeRawPtr<ReferenceFilter> referenceFilter = ReferenceFilte rBuilder::build(style.effectiveZoom(), toElement(enclosingElement()), nullptr, r eferenceOperation);
2582 referenceFilter->setLastEffect(ReferenceFilterBuilder::build(referen ceFilter.get(), toElement(enclosingElement()), referenceFilter->sourceGraphic(),
2583 referenceOperation));
2584 referenceOperation.setFilter(referenceFilter.release()); 2582 referenceOperation.setFilter(referenceFilter.release());
2585 } 2583 }
2586 } 2584 }
2587 2585
2588 return filters; 2586 return filters;
2589 } 2587 }
2590 2588
2591 void DeprecatedPaintLayer::updateOrRemoveFilterClients() 2589 void DeprecatedPaintLayer::updateOrRemoveFilterClients()
2592 { 2590 {
2593 if (!hasFilter()) { 2591 if (!hasFilter()) {
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
2700 2698
2701 void showLayerTree(const blink::LayoutObject* layoutObject) 2699 void showLayerTree(const blink::LayoutObject* layoutObject)
2702 { 2700 {
2703 if (!layoutObject) { 2701 if (!layoutObject) {
2704 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n"); 2702 fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
2705 return; 2703 return;
2706 } 2704 }
2707 showLayerTree(layoutObject->enclosingLayer()); 2705 showLayerTree(layoutObject->enclosingLayer());
2708 } 2706 }
2709 #endif 2707 #endif
OLDNEW
« no previous file with comments | « Source/core/layout/svg/ReferenceFilterBuilder.cpp ('k') | Source/core/paint/FilterEffectBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698