Issue 1232783007: Cleanup: Fix some misc nits in printing code.

Issue 1232783007: Cleanup: Fix some misc nits in printing code. (Closed)

Created:
5 years, 5 months ago by Lei Zhang

Modified:
5 years, 5 months ago

Reviewers:
tommycli

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Cleanup: Fix some misc nits in printing code. Committed: https://crrev.com/e3f5f5d4f7d56dac0e9a59ee9cf775e5e796d2f8 Cr-Commit-Position: refs/heads/master@{#339101}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -46 lines)			Patch
M	chrome/browser/printing/print_preview_context_menu_observer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_preview_data_service.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/printing/print_preview_data_service.cc	View	3 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/printing/print_preview_dialog_controller.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/print_preview_dialog_controller.cc	View	5 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/printing/print_preview_dialog_controller_browsertest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/print_preview_dialog_controller_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.cc	View	3 chunks	+11 lines, -13 lines	0 comments	Download
M	printing/pdf_metafile_skia.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232783007/1

5 years, 5 months ago (2015-07-16 18:26:14 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-16 19:48:51 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e3f5f5d4f7d56dac0e9a59ee9cf775e5e796d2f8
Cr-Commit-Position: refs/heads/master@{#339101}