Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: chrome/browser/printing/print_preview_dialog_controller_unittest.cc

Issue 1232783007: Cleanup: Fix some misc nits in printing code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/printing/print_preview_dialog_controller.h" 5 #include "chrome/browser/printing/print_preview_dialog_controller.h"
6 #include "chrome/browser/printing/print_preview_test.h" 6 #include "chrome/browser/printing/print_preview_test.h"
7 #include "chrome/browser/printing/print_view_manager.h" 7 #include "chrome/browser/printing/print_view_manager.h"
8 #include "chrome/browser/ui/browser_commands.h" 8 #include "chrome/browser/ui/browser_commands.h"
9 #include "chrome/browser/ui/browser_finder.h" 9 #include "chrome/browser/ui/browser_finder.h"
10 #include "chrome/browser/ui/tabs/tab_strip_model.h" 10 #include "chrome/browser/ui/tabs/tab_strip_model.h"
11 #include "chrome/browser/ui/webui/print_preview/print_preview_ui.h" 11 #include "chrome/browser/ui/webui/print_preview/print_preview_ui.h"
12 #include "content/public/browser/navigation_details.h" 12 #include "content/public/browser/navigation_details.h"
13 #include "content/public/common/url_constants.h" 13 #include "content/public/common/url_constants.h"
14 14
15 using content::WebContents; 15 using content::WebContents;
16 16
17 namespace printing { 17 namespace printing {
18 18
19 typedef PrintPreviewTest PrintPreviewDialogControllerUnitTest; 19 using PrintPreviewDialogControllerUnitTest = PrintPreviewTest;
20 20
21 // Create/Get a preview dialog for initiator. 21 // Create/Get a preview dialog for initiator.
22 TEST_F(PrintPreviewDialogControllerUnitTest, GetOrCreatePreviewDialog) { 22 TEST_F(PrintPreviewDialogControllerUnitTest, GetOrCreatePreviewDialog) {
23 // Lets start with one window with one tab. 23 // Lets start with one window with one tab.
24 EXPECT_EQ(1u, chrome::GetTotalBrowserCount()); 24 EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
25 EXPECT_EQ(0, browser()->tab_strip_model()->count()); 25 EXPECT_EQ(0, browser()->tab_strip_model()->count());
26 chrome::NewTab(browser()); 26 chrome::NewTab(browser());
27 EXPECT_EQ(1, browser()->tab_strip_model()->count()); 27 EXPECT_EQ(1, browser()->tab_strip_model()->count());
28 28
29 // Create a reference to initiator contents. 29 // Create a reference to initiator contents.
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 dialog_controller->GetOrCreatePreviewDialog(initiator); 153 dialog_controller->GetOrCreatePreviewDialog(initiator);
154 154
155 // New print preview dialog is a constrained window, so the number of tabs is 155 // New print preview dialog is a constrained window, so the number of tabs is
156 // still 1. 156 // still 1.
157 EXPECT_EQ(1, browser()->tab_strip_model()->count()); 157 EXPECT_EQ(1, browser()->tab_strip_model()->count());
158 // Verify a new print preview dialog has been created. 158 // Verify a new print preview dialog has been created.
159 EXPECT_NE(new_preview_dialog, preview_dialog); 159 EXPECT_NE(new_preview_dialog, preview_dialog);
160 } 160 }
161 161
162 } // namespace printing 162 } // namespace printing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698