Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6937)

Unified Diff: chrome/browser/printing/print_preview_data_service.h

Issue 1232783007: Cleanup: Fix some misc nits in printing code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_preview_data_service.h
diff --git a/chrome/browser/printing/print_preview_data_service.h b/chrome/browser/printing/print_preview_data_service.h
index ca2fe83e2a7fd2bfbadafbc6ad6d3bf70bca2316..9ed94fdd70f27f175812c351b4e786b69da21f63 100644
--- a/chrome/browser/printing/print_preview_data_service.h
+++ b/chrome/browser/printing/print_preview_data_service.h
@@ -28,7 +28,7 @@ class PrintPreviewDataService {
// |printing::COMPLETE_PREVIEW_DOCUMENT_INDEX| to represent complete preview
// data. Use |index| to retrieve a specific preview page data. |data| is set
// to NULL if the requested page is not yet available.
- void GetDataEntry(int32 preview_ui_id, int index,
+ void GetDataEntry(int32_t preview_ui_id, int index,
scoped_refptr<base::RefCountedBytes>* data);
// Set/Update the data entry in PrintPreviewDataStore. |index| is zero-based
@@ -36,14 +36,14 @@ class PrintPreviewDataService {
// preview data. Use |index| to set/update a specific preview page data.
// NOTE: PrintPreviewDataStore owns the data. Do not refcount |data| before
// calling this function. It will be refcounted in PrintPreviewDataStore.
- void SetDataEntry(int32 preview_ui_id, int index,
+ void SetDataEntry(int32_t preview_ui_id, int index,
const base::RefCountedBytes* data);
// Remove the corresponding PrintPreviewUI entry from the map.
- void RemoveEntry(int32 preview_ui_id);
+ void RemoveEntry(int32_t preview_ui_id);
// Returns the available draft page count.
- int GetAvailableDraftPageCount(int32 preview_ui_id);
+ int GetAvailableDraftPageCount(int32_t preview_ui_id);
private:
friend struct DefaultSingletonTraits<PrintPreviewDataService>;
@@ -51,8 +51,8 @@ class PrintPreviewDataService {
// 1:1 relationship between PrintPreviewUI and data store object.
// Key: PrintPreviewUI ID.
// Value: Print preview data store object.
- typedef std::map<int32, scoped_refptr<PrintPreviewDataStore> >
- PreviewDataStoreMap;
+ using PreviewDataStoreMap =
+ std::map<int32_t, scoped_refptr<PrintPreviewDataStore>>;
PrintPreviewDataService();
virtual ~PrintPreviewDataService();
« no previous file with comments | « chrome/browser/printing/print_preview_context_menu_observer.cc ('k') | chrome/browser/printing/print_preview_data_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698