chrome/browser/printing/print_preview_dialog_controller_browsertest.cc - Issue 1232783007: Cleanup: Fix some misc nits in printing code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

Issue 1232783007: Cleanup: Fix some misc nits in printing code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_dialog_controller.cc ('k') | chrome/browser/printing/print_preview_dialog_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

diff --git a/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc b/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

index dee03366c90b0525188d8264163e8190e4053e77..938faae1337f4a1efa3a02b9f80edc1bb1e960e3 100644

--- a/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

+++ b/chrome/browser/printing/print_preview_dialog_controller_browsertest.cc

@@ -146,7 +146,7 @@ void CheckPdfPluginForRenderFrame(content::RenderFrameHost* frame) {

class PrintPreviewDialogControllerBrowserTest : public InProcessBrowserTest {

public:

- PrintPreviewDialogControllerBrowserTest() : initiator_(NULL) {}

+ PrintPreviewDialogControllerBrowserTest() : initiator_(nullptr) {}

~PrintPreviewDialogControllerBrowserTest() override {}

WebContents* initiator() {

@@ -190,7 +190,7 @@ class PrintPreviewDialogControllerBrowserTest : public InProcessBrowserTest {

void TearDownOnMainThread() override {

cloned_tab_observer_.reset();

- initiator_ = NULL;

+ initiator_ = nullptr;

}

RequestPrintPreviewObserver* request_preview_dialog_observer() {