Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1232463006: Fix up -Winconsistent-missing-override (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix up -Winconsistent-missing-override (and a couple presubmit fixes) This allows us to turn back on -Werror for LLVM coverage builds, and more generally supports building with Clang 3.7. No public API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/f059900f75639f1b1a03f2c25333ef9aa22d58b8

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix gmpb #

Patch Set 4 : llvm_coverage_build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -249 lines) Patch
M bench/AlternatingColorPatternBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/BitmapBench.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M bench/BitmapScaleBench.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M bench/ChecksumBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/GrMemoryPoolBench.cpp View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M bench/InterpBench.cpp View 2 chunks +9 lines, -2 lines 0 comments Download
M bench/MathBench.cpp View 20 chunks +32 lines, -35 lines 0 comments Download
M bench/Matrix44Bench.cpp View 11 chunks +12 lines, -12 lines 0 comments Download
M bench/MatrixBench.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M bench/MutexBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/PathBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/PictureNestingBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M bench/RefCntBench.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M bench/RegionBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/StrokeBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/TextBench.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M bench/TextBlobBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/bitmapshader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/complexclip2.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/dcshader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadows.cpp View 1 chunk +71 lines, -71 lines 0 comments Download
M gm/simpleaaclip.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M include/xml/SkXMLWriter.h View 2 chunks +5 lines, -5 lines 0 comments Download
M samplecode/SampleApp.cpp View 6 chunks +7 lines, -9 lines 0 comments Download
M samplecode/SampleCamera.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleFatBits.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M samplecode/SampleLayers.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M samplecode/SampleLines.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleManyRects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePatch.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M samplecode/SamplePath.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M samplecode/SamplePathClip.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SamplePathFuzz.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/animator/SkXMLAnimatorWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFunction.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkRWBuffer.cpp View 7 chunks +16 lines, -16 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLPathProgram.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tools/llvm_coverage_build View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232463006/20001
5 years, 5 months ago (2015-07-10 13:17:09 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/1889) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years, 5 months ago (2015-07-10 13:18:42 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232463006/40001
5 years, 5 months ago (2015-07-10 13:20:29 UTC) #6
mtklein_C
5 years, 5 months ago (2015-07-10 13:26:46 UTC) #8
borenet
LGTM
5 years, 5 months ago (2015-07-13 12:48:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232463006/60001
5 years, 5 months ago (2015-07-13 12:49:55 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 13:18:43 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f059900f75639f1b1a03f2c25333ef9aa22d58b8

Powered by Google App Engine
This is Rietveld 408576698