Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: include/xml/SkXMLWriter.h

Issue 1232463006: Fix up -Winconsistent-missing-override (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: llvm_coverage_build Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gm/simpleaaclip.cpp ('k') | samplecode/SampleApp.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2006 The Android Open Source Project 2 * Copyright 2006 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkXMLWriter_DEFINED 8 #ifndef SkXMLWriter_DEFINED
9 #define SkXMLWriter_DEFINED 9 #define SkXMLWriter_DEFINED
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 private: 58 private:
59 bool fDoEscapeMarkup; 59 bool fDoEscapeMarkup;
60 // illegal 60 // illegal
61 SkXMLWriter& operator=(const SkXMLWriter&); 61 SkXMLWriter& operator=(const SkXMLWriter&);
62 }; 62 };
63 63
64 class SkXMLStreamWriter : public SkXMLWriter { 64 class SkXMLStreamWriter : public SkXMLWriter {
65 public: 65 public:
66 SkXMLStreamWriter(SkWStream*); 66 SkXMLStreamWriter(SkWStream*);
67 virtual ~SkXMLStreamWriter(); 67 virtual ~SkXMLStreamWriter();
68 virtual void writeHeader(); 68 void writeHeader() override;
69 SkDEBUGCODE(static void UnitTest();) 69 SkDEBUGCODE(static void UnitTest();)
70 70
71 protected: 71 protected:
72 void onStartElementLen(const char elem[], size_t length) override; 72 void onStartElementLen(const char elem[], size_t length) override;
73 void onEndElement() override; 73 void onEndElement() override;
74 void onAddAttributeLen(const char name[], const char value[], size_t length) override; 74 void onAddAttributeLen(const char name[], const char value[], size_t length) override;
75 void onAddText(const char text[], size_t length) override; 75 void onAddText(const char text[], size_t length) override;
76 76
77 private: 77 private:
78 SkWStream& fStream; 78 SkWStream& fStream;
79 }; 79 };
80 80
81 class SkXMLParserWriter : public SkXMLWriter { 81 class SkXMLParserWriter : public SkXMLWriter {
82 public: 82 public:
83 SkXMLParserWriter(SkXMLParser*); 83 SkXMLParserWriter(SkXMLParser*);
84 virtual ~SkXMLParserWriter(); 84 virtual ~SkXMLParserWriter();
85 protected: 85 protected:
86 virtual void onStartElementLen(const char elem[], size_t length); 86 void onStartElementLen(const char elem[], size_t length) override;
87 virtual void onEndElement(); 87 void onEndElement() override;
88 virtual void onAddAttributeLen(const char name[], const char value[], size_t length); 88 void onAddAttributeLen(const char name[], const char value[], size_t length) override;
89 virtual void onAddText(const char text[], size_t length) override; 89 void onAddText(const char text[], size_t length) override;
90 private: 90 private:
91 SkXMLParser& fParser; 91 SkXMLParser& fParser;
92 }; 92 };
93 93
94 94
95 #endif 95 #endif
OLDNEW
« no previous file with comments | « gm/simpleaaclip.cpp ('k') | samplecode/SampleApp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698