Issue 12323002: In LiveEdit API expose important control-flow parameter (fixing TODO)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12323002: In LiveEdit API expose important control-flow parameter (fixing TODO) (Closed)

Created:
7 years, 10 months ago by Peter Rybin

Modified:
7 years, 10 months ago

Reviewers:
apavlov

CC:
chromedevtools-codereview_googlegroups.com

Base URL:
https://chromedevtools.googlecode.com/svn/trunk

Visibility:
Public.

In LiveEdit API expose important control-flow parameter (fixing TODO) Committed: https://code.google.com/p/chromedevtools/source/detail?r=1140

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -11 lines)			Patch
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PreviewLoader.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PushChangesWizard.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipScriptImpl.java	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipScriptImpl.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/UpdatableScript.java	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/ScriptImpl.java	View	3 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

apavlov

LGTM with a comment You don't seem to use the added boolean, do you? You ...

7 years, 10 months ago (2013-02-20 08:40:23 UTC) #2

Peter Rybin

On 2013/02/20 08:40:23, apavlov wrote: > LGTM with a comment > > You don't seem ...

7 years, 10 months ago (2013-02-20 19:21:39 UTC) #3

Message was sent while issue was closed.

Committed manually as r1140 (presubmit successful).