Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PushChangesWizard.java

Issue 12323002: In LiveEdit API expose important control-flow parameter (fixing TODO) (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.debug.ui.liveedit; 5 package org.chromium.debug.ui.liveedit;
6 6
7 import java.util.ArrayList; 7 import java.util.ArrayList;
8 import java.util.Arrays; 8 import java.util.Arrays;
9 import java.util.List; 9 import java.util.List;
10 10
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 private static LiveEditResultDialog.SingleInput performSingleVmUpdate( 251 private static LiveEditResultDialog.SingleInput performSingleVmUpdate(
252 final PushChangesPlan changesPlan, IProgressMonitor monitor) { 252 final PushChangesPlan changesPlan, IProgressMonitor monitor) {
253 final LiveEditResultDialog.SingleInput[] input = { null }; 253 final LiveEditResultDialog.SingleInput[] input = { null };
254 254
255 UpdatableScript.UpdateCallback callback = new UpdatableScript.UpdateCallback () { 255 UpdatableScript.UpdateCallback callback = new UpdatableScript.UpdateCallback () {
256 public void failure(String message, UpdatableScript.Failure failure) { 256 public void failure(String message, UpdatableScript.Failure failure) {
257 String text = NLS.bind("Failure: {0}", message); 257 String text = NLS.bind("Failure: {0}", message);
258 input[0] = LiveEditResultDialog.createTextInput(text, changesPlan, 258 input[0] = LiveEditResultDialog.createTextInput(text, changesPlan,
259 failure); 259 failure);
260 } 260 }
261 public void success(Object report, 261 public void success(boolean resumed, Object report,
262 final UpdatableScript.ChangeDescription changeDescription) { 262 final UpdatableScript.ChangeDescription changeDescription) {
263 if (changeDescription == null) { 263 if (changeDescription == null) {
264 input[0] = LiveEditResultDialog.createTextInput( 264 input[0] = LiveEditResultDialog.createTextInput(
265 Messages.PushChangesWizard_EMPTY_CHANGE, changesPlan); 265 Messages.PushChangesWizard_EMPTY_CHANGE, changesPlan);
266 } else { 266 } else {
267 final String oldScriptName = changeDescription.getCreatedScriptName(); 267 final String oldScriptName = changeDescription.getCreatedScriptName();
268 final LiveEditResultDialog.OldScriptData oldScriptData; 268 final LiveEditResultDialog.OldScriptData oldScriptData;
269 if (oldScriptName == null) { 269 if (oldScriptName == null) {
270 oldScriptData = null; 270 oldScriptData = null;
271 } else { 271 } else {
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 306
307 CallbackSemaphore syncCallback = new CallbackSemaphore(); 307 CallbackSemaphore syncCallback = new CallbackSemaphore();
308 RelayOk relayOk = changesPlan.execute(false, callback, syncCallback); 308 RelayOk relayOk = changesPlan.execute(false, callback, syncCallback);
309 syncCallback.acquireDefault(relayOk); 309 syncCallback.acquireDefault(relayOk);
310 310
311 monitor.done(); 311 monitor.done();
312 312
313 return input[0]; 313 return input[0];
314 } 314 }
315 } 315 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698