Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Side by Side Diff: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java

Issue 12323002: In LiveEdit API expose important control-flow parameter (fixing TODO) (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PreviewLoader.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.debug.ui.actions; 5 package org.chromium.debug.ui.actions;
6 6
7 import java.util.List; 7 import java.util.List;
8 8
9 import org.chromium.debug.core.ChromiumDebugPlugin; 9 import org.chromium.debug.core.ChromiumDebugPlugin;
10 import org.chromium.debug.core.model.PushChangesPlan; 10 import org.chromium.debug.core.model.PushChangesPlan;
(...skipping 22 matching lines...) Expand all
33 execute(pair, shell, positionHighlighter); 33 execute(pair, shell, positionHighlighter);
34 } 34 }
35 } 35 }
36 36
37 private void execute(final ScriptTargetMapping filePair, final Shell shell, 37 private void execute(final ScriptTargetMapping filePair, final Shell shell,
38 final LiveEditResultDialog.ErrorPositionHighlighter positionHighlighter) { 38 final LiveEditResultDialog.ErrorPositionHighlighter positionHighlighter) {
39 final PushChangesPlan plan = PushChangesPlan.create(filePair); 39 final PushChangesPlan plan = PushChangesPlan.create(filePair);
40 40
41 UpdatableScript.UpdateCallback callback = new UpdatableScript.UpdateCallback () { 41 UpdatableScript.UpdateCallback callback = new UpdatableScript.UpdateCallback () {
42 @Override 42 @Override
43 public void success(Object report, ChangeDescription changeDescription) { 43 public void success(boolean resumed, Object report, ChangeDescription chan geDescription) {
44 ChromiumDebugPlugin.log(new Status(IStatus.OK, ChromiumDebugPlugin.PLUGI N_ID, 44 ChromiumDebugPlugin.log(new Status(IStatus.OK, ChromiumDebugPlugin.PLUGI N_ID,
45 "Script has been successfully updated on remote: " + report)); //$NO N-NLS-1$ 45 "Script has been successfully updated on remote: " + report)); //$NO N-NLS-1$
46 } 46 }
47 47
48 @Override 48 @Override
49 public void failure(final String message, final UpdatableScript.Failure fa ilure) { 49 public void failure(final String message, final UpdatableScript.Failure fa ilure) {
50 shell.getDisplay().asyncExec(new Runnable() { 50 shell.getDisplay().asyncExec(new Runnable() {
51 @Override 51 @Override
52 public void run() { 52 public void run() {
53 SingleInput textInput = LiveEditResultDialog.createTextInput(message , plan, 53 SingleInput textInput = LiveEditResultDialog.createTextInput(message , plan,
(...skipping 16 matching lines...) Expand all
70 } 70 }
71 final ITextEditor textEditor = (ITextEditor) workbenchPart; 71 final ITextEditor textEditor = (ITextEditor) workbenchPart;
72 return new LiveEditResultDialog.ErrorPositionHighlighter() { 72 return new LiveEditResultDialog.ErrorPositionHighlighter() {
73 @Override 73 @Override
74 public void highlight(int offset, int length) { 74 public void highlight(int offset, int length) {
75 textEditor.selectAndReveal(offset, length); 75 textEditor.selectAndReveal(offset, length);
76 } 76 }
77 }; 77 };
78 } 78 }
79 } 79 }
OLDNEW
« no previous file with comments | « no previous file | plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PreviewLoader.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698